Swagger change for pre and post script

[jemex]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3125

[AutorestCI]

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#293

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3938

[AutorestCI]

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3115

[annatisch]

@jemex - this PR includes breaking changes yet does not alter the API version.
Were these changes actually made to the service without updating the API version? Or were these always errors in the spec?

Also, please fix the semantic and model validation errors in CI:

 error : 
code: OBJECT_MISSING_REQUIRED_PROPERTY_DEFINITION
message: 'Missing required property definition: updateConfiguration'
path:
  - definitions
  - softareUpdateConfigurationRunTasks
jsonUrl: >-
  specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfigurationRun.json


 error : 
code: OBJECT_MISSING_REQUIRED_PROPERTY_DEFINITION
message: 'Missing required property definition: scheduleInfo'
path:
  - definitions
  - softareUpdateConfigurationRunTasks
jsonUrl: >-
  specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfigurationRun.json

[jemex]

@annatisch, this PR doesn't have breaking changes. we only added new properties to the existing model.

[annatisch]

@jemex - Ah you're right - but it's currently broken because "required" is incorrectly indented to become part of properties:

azure-rest-api-specs/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json

Line 358 in b486fcc

"required": [

Once you fix that it will no longer be breaking :)

[jemex]

@annatisch - Thank you so much for the feedback. I have updated the "required" field. the checks takes longer to validate them, what do I need to do?

[jemex]

@annatisch- can you merge this PR please if you it looks ok to you.

[annatisch]

@jemex - Can you please fix the model validation errors? I will review once CI is clean:

 error : 
operationId: SoftwareUpdateConfigurations_Create
source: response
responseCode: '200'
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - locations
  message: 'Additional properties not allowed: locations'
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/createSoftwareUpdateConfiguration.json

 error : 
operationId: SoftwareUpdateConfigurations_Create
source: response
responseCode: '201'
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - locations
  message: 'Additional properties not allowed: locations'
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/createSoftwareUpdateConfiguration.json

 error : 
operationId: SoftwareUpdateConfigurations_GetByName
source: response
responseCode: '200'
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - locations
  message: 'Additional properties not allowed: locations'
  jsonUrl: >-
    specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/examples/softwareUpdateConfiguration/getSoftwareUpdateConfigurationByName.json

[annatisch]

Looks pretty good - just a couple of minor things to improve the generated code :)

[jemex]

@annatisch - I have resolved the feedback. Can you tell me if I have missed anything? If not and if it looks good, can you merge , please?

[annatisch]

Thanks @jemex
You missed one:
https://github.com/Azure/azure-rest-api-specs/pull/4298/files#diff-78182b2e6ebf616ace2b0ed13f9e4c96R281

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[annatisch]

@AutorestCI regenerate azure-sdk-for-python