Merge Management.Sql backport branch into mainline branch#4262
Merge Management.Sql backport branch into mainline branch#4262jaredmoo wants to merge 2 commits intoAzure:psSdkJson6from
Conversation
…h Instance Failover Group APIs (Azure#4259) * adding generated files and tests for Cloud Lifter work * updating the SDK version in .csproj and AssemblyInfo.cs files * adding Managed Instance test recording * addressing some comments * changing tabs into spaces * Regen from swagger * Updating the release note with the current changes
|
@ziwa-msft and @shahabhijeet FYI. This is not urgent (does not block any release). |
|
I don't quite follow. |
|
There are no files changed, but there are merge conflicts that were resolved. All of them were resolved by 'keep ours', i.e. keep the psSdkJson6 change (not SqlMgmt-CloudLifter). |
|
I still don't know why you would like to merge it. What happens if you don't merge it? |
|
Cherry picking in general is bad (Raymond Chen wrote a fascinating series of articles about it: https://blogs.msdn.microsoft.com/oldnewthing/20180323-01/?p=98325 ). There will soon be another PR for short-term retention going into SqlMgmt-CloudLifter branch, and when that PR lands we want to merge it into psSdkJson6 so that both branches have the same changes for the new feature. Merging this now resolved conflicts and will make that future merge easier. If you want, we can hold off on this for now until that short term retention change lands in SqlMgmt-CloudLifter. |
|
yes let's hold off on this one. |
|
No problem. |
Description
We recently added support for SQL Managed Instance, Managed Instance database, and Managed Instance failover groups to the mainline psSdkJson6 branch in PR #4244 and released as 1.15.0-preview.
We then realised that we wanted to backport this change to before the 1.14.0-preview breaking changes, so in PR #4257 we cherry picked these changes into the new backport branch 'ManagementSql-CloudLifter' and released as 1.13.1-preview.
In order to reconcile these cherry picks and keep history healthy moving forward, we need to merge from the backport branch (ManagementSql-CloudLifter) into the mainline branch (psSdkJson6). This PR does that. There are no files changed, just merged from ManagementSql-CloudLifter into psSdkJson6 and then resolved conflicts.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.