Skip to content

Conversation

@ziwa-msft
Copy link
Contributor

Description

I have rebased the .Net SDK to 1.13.1 by cherrypicking changes for InstanceFailoverGroup on top of the 1.13.0 branch.

The files are generated by targeting composite v2 APIs. Link to swagger template: ziwa-msft/azure-rest-api-specs@b2b5156

We have verified that all tests are passing locally.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • [x ] Title of the pull request is clear and informative.
  • [ x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • [x ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • [x ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • [x ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before pushing, at least build your project as below
msbuild build.proj /t:Build /p:Scope=SDKs\SqlManagement

@shahabhijeet shahabhijeet merged commit c7aef14 into Azure:SqlMgmt-CloudLifter Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants