Rebasing .NET SDK To Version 1.31.1 With Instance Failover Group APIs#4257
Closed
ziwa-msft wants to merge 7 commits intoAzure:ManagementSql-CloudLifterfrom
Closed
Rebasing .NET SDK To Version 1.31.1 With Instance Failover Group APIs#4257ziwa-msft wants to merge 7 commits intoAzure:ManagementSql-CloudLifterfrom
ziwa-msft wants to merge 7 commits intoAzure:ManagementSql-CloudLifterfrom
Conversation
jaredmoo
suggested changes
Apr 23, 2018
Contributor
jaredmoo
left a comment
There was a problem hiding this comment.
Looks great other than release notes. Thx
| <Version>1.13.0-preview</Version> | ||
| <Version>1.13.1-preview</Version> | ||
| <PackageTags>Microsoft Azure SQL Management;SQL;SQL Management;</PackageTags> | ||
| <PackageReleaseNotes> |
Contributor
There was a problem hiding this comment.
Please delete the current release notes and add new release notes:
- Added support for Managed Instances, Managed Instance databases, and Managed Instance failover groups.
Contributor
Author
There was a problem hiding this comment.
Thanks Jared. I have update the release note now.
Contributor
|
Will merge once CI passes |
Contributor
|
@ziwa-msft while you are at it, please pull down the latest changes from upstream and run the code generation again (the txt file should not be displayed as a binary on the PR) |
jaredmoo
approved these changes
Apr 23, 2018
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have rebased the .Net SDK to 1.13.1 by cherrypicking changes for InstanceFailoverGroup on top of the 1.13.0 branch.
The files are generated by targeting composite v2 APIs. Link to swagger template: ziwa-msft/azure-rest-api-specs@b2b5156
We have verified that all tests are passing locally.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.