Skip to content

Azure.Core 2.0: Update RequestFailedException #42323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
annelo-msft wants to merge 42 commits into from
Closed

Azure.Core 2.0: Update RequestFailedException #42323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
ef2eaa4
initial checkin
annelo-msft Feb 27, 2024
abd2672
WIP
annelo-msft Feb 27, 2024
0e4a202
Tables
annelo-msft Feb 27, 2024
a781cf0
updates
annelo-msft Feb 27, 2024
db9d9b7
Add tests
annelo-msft Feb 27, 2024
918a011
updates
annelo-msft Feb 27, 2024
f7f9abe
API updates
annelo-msft Feb 27, 2024
718a99a
Add ResponseHeadersAdapter
annelo-msft Feb 28, 2024
76055b3
rework buffering a bit
annelo-msft Feb 28, 2024
fa98e1e
revert
annelo-msft Feb 28, 2024
3474932
reshuffle
annelo-msft Feb 28, 2024
6dbac06
fix
annelo-msft Feb 28, 2024
bbde0a1
Merge remote-tracking branch 'upstream/feature/azure.core-2.0' into c…
annelo-msft Feb 28, 2024
4804347
add tests
annelo-msft Feb 28, 2024
d49ba41
nits
annelo-msft Feb 28, 2024
9bd51c7
nits
annelo-msft Feb 28, 2024
bf68462
Initial files
annelo-msft Feb 28, 2024
3f3b211
fix build
annelo-msft Feb 28, 2024
1c87cc2
update comment on NullableResponse<T>.DefaultResponse
annelo-msft Feb 28, 2024
35a54bf
Merge branch 'core2.0-response' into core2.0-message
annelo-msft Feb 28, 2024
025895d
nits
annelo-msft Feb 28, 2024
a48a5f3
Merge remote-tracking branch 'upstream/feature/azure.core-2.0' into c…
annelo-msft Feb 28, 2024
26f911a
use default
annelo-msft Feb 28, 2024
52275e9
Allow setting message.ResponseClassifier from the base type property
annelo-msft Feb 29, 2024
27cb6d7
update exception text
annelo-msft Feb 29, 2024
531f077
add test that fails if classifier TryClassify methods are unsealed
annelo-msft Feb 29, 2024
89f9b7a
updates
annelo-msft Feb 29, 2024
7abc896
remove NetworkTimeout logic until we can implement it e2e
annelo-msft Feb 29, 2024
e0507d7
remove NetworkTimeout logic until we can implement it e2e
annelo-msft Feb 29, 2024
a30e535
add comment to adapter
annelo-msft Feb 29, 2024
9c16d49
address PR feedback
annelo-msft Feb 29, 2024
6ae17b5
Initial checkin for policy only
annelo-msft Feb 29, 2024
2a109e6
updates from PR feedback
annelo-msft Feb 29, 2024
8e4a3cc
Merge remote-tracking branch 'origin/core2.0-message' into core2.0-tr…
annelo-msft Feb 29, 2024
6cac731
make HttpPipelineTransport inherit from PipelineTransport
annelo-msft Feb 29, 2024
a729812
Merge remote-tracking branch 'upstream/feature/azure.core-2.0' into c…
annelo-msft Feb 29, 2024
35660e7
export API
annelo-msft Feb 29, 2024
8bd5315
move to full transport implementation
annelo-msft Mar 1, 2024
549651d
address feedback from #41773
annelo-msft Mar 1, 2024
2cf73fc
fix and export API
annelo-msft Mar 1, 2024
f30d9ce
update adapter comment based on pr fb
annelo-msft Mar 1, 2024
833c2b4
Initial files
annelo-msft Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions sdk/core/Azure.Core/api/Azure.Core.net461.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,24 +220,24 @@ public void AddPolicy(Azure.Core.Pipeline.HttpPipelinePolicy policy, Azure.Core.
protected override void Apply(System.ClientModel.Primitives.PipelineMessage message) { }
public static implicit operator Azure.RequestContext (Azure.ErrorOptions options) { throw null; }
}
public partial class RequestFailedException : System.Exception, System.Runtime.Serialization.ISerializable
public partial class RequestFailedException : System.ClientModel.ClientResultException, System.Runtime.Serialization.ISerializable
{
public RequestFailedException(Azure.Response response) { }
public RequestFailedException(Azure.Response response, System.Exception? innerException) { }
public RequestFailedException(Azure.Response response, System.Exception? innerException, Azure.Core.RequestFailedDetailsParser? detailsParser) { }
public RequestFailedException(Azure.Response response) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
public RequestFailedException(Azure.Response response, System.Exception? innerException) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
public RequestFailedException(Azure.Response response, System.Exception? innerException, Azure.Core.RequestFailedDetailsParser? detailsParser) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
public RequestFailedException(int status, string message) { }
public RequestFailedException(int status, string message) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
public RequestFailedException(int status, string message, System.Exception? innerException) { }
public RequestFailedException(int status, string message, System.Exception? innerException) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
public RequestFailedException(int status, string message, string? errorCode, System.Exception? innerException) { }
protected RequestFailedException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
public RequestFailedException(string message) { }
public RequestFailedException(string message, System.Exception? innerException) { }
public RequestFailedException(int status, string message, string? errorCode, System.Exception? innerException) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
protected RequestFailedException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
public RequestFailedException(string message) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
public RequestFailedException(string message, System.Exception? innerException) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
public string? ErrorCode { get { throw null; } }
public int Status { get { throw null; } }
public static System.Threading.Tasks.ValueTask<Azure.RequestFailedException> CreateAsync(Azure.Response response, Azure.Core.RequestFailedDetailsParser? parser = null, System.Exception? innerException = null) { throw null; }
public override void GetObjectData(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
public Azure.Response? GetRawResponse() { throw null; }
public new Azure.Response? GetRawResponse() { throw null; }
}
public abstract partial class Response : System.ClientModel.Primitives.PipelineResponse
{
Expand Down Expand Up @@ -1040,11 +1040,13 @@ public HttpPipelineOptions(Azure.Core.ClientOptions options) { }
public Azure.Core.RequestFailedDetailsParser RequestFailedDetailsParser { get { throw null; } set { } }
public Azure.Core.ResponseClassifier? ResponseClassifier { get { throw null; } set { } }
}
public abstract partial class HttpPipelinePolicy
public abstract partial class HttpPipelinePolicy : System.ClientModel.Primitives.PipelinePolicy
{
protected HttpPipelinePolicy() { }
public abstract void Process(Azure.Core.HttpMessage message, System.ReadOnlyMemory<Azure.Core.Pipeline.HttpPipelinePolicy> pipeline);
public sealed override void Process(System.ClientModel.Primitives.PipelineMessage message, System.Collections.Generic.IReadOnlyList<System.ClientModel.Primitives.PipelinePolicy> pipeline, int currentIndex) { }
public abstract System.Threading.Tasks.ValueTask ProcessAsync(Azure.Core.HttpMessage message, System.ReadOnlyMemory<Azure.Core.Pipeline.HttpPipelinePolicy> pipeline);
public sealed override System.Threading.Tasks.ValueTask ProcessAsync(System.ClientModel.Primitives.PipelineMessage message, System.Collections.Generic.IReadOnlyList<System.ClientModel.Primitives.PipelinePolicy> pipeline, int currentIndex) { throw null; }
protected static void ProcessNext(Azure.Core.HttpMessage message, System.ReadOnlyMemory<Azure.Core.Pipeline.HttpPipelinePolicy> pipeline) { }
protected static System.Threading.Tasks.ValueTask ProcessNextAsync(Azure.Core.HttpMessage message, System.ReadOnlyMemory<Azure.Core.Pipeline.HttpPipelinePolicy> pipeline) { throw null; }
}
Expand All @@ -1056,12 +1058,15 @@ public virtual void OnSendingRequest(Azure.Core.HttpMessage message) { }
public override void Process(Azure.Core.HttpMessage message, System.ReadOnlyMemory<Azure.Core.Pipeline.HttpPipelinePolicy> pipeline) { }
public override System.Threading.Tasks.ValueTask ProcessAsync(Azure.Core.HttpMessage message, System.ReadOnlyMemory<Azure.Core.Pipeline.HttpPipelinePolicy> pipeline) { throw null; }
}
public abstract partial class HttpPipelineTransport
public abstract partial class HttpPipelineTransport : System.ClientModel.Primitives.PipelineTransport
{
protected HttpPipelineTransport() { }
protected sealed override System.ClientModel.Primitives.PipelineMessage CreateMessageCore() { throw null; }
public abstract Azure.Core.Request CreateRequest();
public abstract void Process(Azure.Core.HttpMessage message);
public abstract System.Threading.Tasks.ValueTask ProcessAsync(Azure.Core.HttpMessage message);
protected sealed override void ProcessCore(System.ClientModel.Primitives.PipelineMessage message) { }
protected sealed override System.Threading.Tasks.ValueTask ProcessCoreAsync(System.ClientModel.Primitives.PipelineMessage message) { throw null; }
}
public partial class HttpPipelineTransportOptions
{
Expand Down
33 changes: 19 additions & 14 deletions sdk/core/Azure.Core/api/Azure.Core.net472.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,24 +220,24 @@ public void AddPolicy(Azure.Core.Pipeline.HttpPipelinePolicy policy, Azure.Core.
protected override void Apply(System.ClientModel.Primitives.PipelineMessage message) { }
public static implicit operator Azure.RequestContext (Azure.ErrorOptions options) { throw null; }
}
public partial class RequestFailedException : System.Exception, System.Runtime.Serialization.ISerializable
public partial class RequestFailedException : System.ClientModel.ClientResultException, System.Runtime.Serialization.ISerializable
{
public RequestFailedException(Azure.Response response) { }
public RequestFailedException(Azure.Response response, System.Exception? innerException) { }
public RequestFailedException(Azure.Response response, System.Exception? innerException, Azure.Core.RequestFailedDetailsParser? detailsParser) { }
public RequestFailedException(Azure.Response response) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
public RequestFailedException(Azure.Response response, System.Exception? innerException) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
public RequestFailedException(Azure.Response response, System.Exception? innerException, Azure.Core.RequestFailedDetailsParser? detailsParser) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
public RequestFailedException(int status, string message) { }
public RequestFailedException(int status, string message) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
public RequestFailedException(int status, string message, System.Exception? innerException) { }
public RequestFailedException(int status, string message, System.Exception? innerException) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
public RequestFailedException(int status, string message, string? errorCode, System.Exception? innerException) { }
protected RequestFailedException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
public RequestFailedException(string message) { }
public RequestFailedException(string message, System.Exception? innerException) { }
public RequestFailedException(int status, string message, string? errorCode, System.Exception? innerException) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
protected RequestFailedException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
public RequestFailedException(string message) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
public RequestFailedException(string message, System.Exception? innerException) : base (default(System.ClientModel.Primitives.PipelineResponse), default(System.Exception)) { }
public string? ErrorCode { get { throw null; } }
public int Status { get { throw null; } }
public static System.Threading.Tasks.ValueTask<Azure.RequestFailedException> CreateAsync(Azure.Response response, Azure.Core.RequestFailedDetailsParser? parser = null, System.Exception? innerException = null) { throw null; }
public override void GetObjectData(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
public Azure.Response? GetRawResponse() { throw null; }
public new Azure.Response? GetRawResponse() { throw null; }
}
public abstract partial class Response : System.ClientModel.Primitives.PipelineResponse
{
Expand Down Expand Up @@ -1040,11 +1040,13 @@ public HttpPipelineOptions(Azure.Core.ClientOptions options) { }
public Azure.Core.RequestFailedDetailsParser RequestFailedDetailsParser { get { throw null; } set { } }
public Azure.Core.ResponseClassifier? ResponseClassifier { get { throw null; } set { } }
}
public abstract partial class HttpPipelinePolicy
public abstract partial class HttpPipelinePolicy : System.ClientModel.Primitives.PipelinePolicy
{
protected HttpPipelinePolicy() { }
public abstract void Process(Azure.Core.HttpMessage message, System.ReadOnlyMemory<Azure.Core.Pipeline.HttpPipelinePolicy> pipeline);
public sealed override void Process(System.ClientModel.Primitives.PipelineMessage message, System.Collections.Generic.IReadOnlyList<System.ClientModel.Primitives.PipelinePolicy> pipeline, int currentIndex) { }
public abstract System.Threading.Tasks.ValueTask ProcessAsync(Azure.Core.HttpMessage message, System.ReadOnlyMemory<Azure.Core.Pipeline.HttpPipelinePolicy> pipeline);
public sealed override System.Threading.Tasks.ValueTask ProcessAsync(System.ClientModel.Primitives.PipelineMessage message, System.Collections.Generic.IReadOnlyList<System.ClientModel.Primitives.PipelinePolicy> pipeline, int currentIndex) { throw null; }
protected static void ProcessNext(Azure.Core.HttpMessage message, System.ReadOnlyMemory<Azure.Core.Pipeline.HttpPipelinePolicy> pipeline) { }
protected static System.Threading.Tasks.ValueTask ProcessNextAsync(Azure.Core.HttpMessage message, System.ReadOnlyMemory<Azure.Core.Pipeline.HttpPipelinePolicy> pipeline) { throw null; }
}
Expand All @@ -1056,12 +1058,15 @@ public virtual void OnSendingRequest(Azure.Core.HttpMessage message) { }
public override void Process(Azure.Core.HttpMessage message, System.ReadOnlyMemory<Azure.Core.Pipeline.HttpPipelinePolicy> pipeline) { }
public override System.Threading.Tasks.ValueTask ProcessAsync(Azure.Core.HttpMessage message, System.ReadOnlyMemory<Azure.Core.Pipeline.HttpPipelinePolicy> pipeline) { throw null; }
}
public abstract partial class HttpPipelineTransport
public abstract partial class HttpPipelineTransport : System.ClientModel.Primitives.PipelineTransport
{
protected HttpPipelineTransport() { }
protected sealed override System.ClientModel.Primitives.PipelineMessage CreateMessageCore() { throw null; }
public abstract Azure.Core.Request CreateRequest();
public abstract void Process(Azure.Core.HttpMessage message);
public abstract System.Threading.Tasks.ValueTask ProcessAsync(Azure.Core.HttpMessage message);
protected sealed override void ProcessCore(System.ClientModel.Primitives.PipelineMessage message) { }
protected sealed override System.Threading.Tasks.ValueTask ProcessCoreAsync(System.ClientModel.Primitives.PipelineMessage message) { throw null; }
}
public partial class HttpPipelineTransportOptions
{
Expand Down
Loading