Merged
Conversation
The focus of these changes is to address a race condition where calling `IsRunning` concurrently with starting/stopping the processor could cause a semaphore to be double-released. As part of this fix, the approach used to detect when a semaphore should be released has been changed to consider the semaphore count rather than using a sentinal variable. Also fixed was an issue where the processor would leak a quota exceeded exception during startup validation if there were more than 4 other processors starting concurrently. The partition chosen for validation is now randomized and a quota exceeded response is now considered a successful validation.
jsquire
added
Event Hubs
Client
Member
Author
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsquire
commented
Dec 5, 2023
Collaborator
|
API change check API changes are not detected in this pull request. |
jsquire
commented
Dec 5, 2023
christothes
approved these changes
Dec 5, 2023
m-redding
approved these changes
Dec 5, 2023
Co-authored-by: Madalyn Redding <66138537+m-redding@users.noreply.github.com>
Co-authored-by: Madalyn Redding <66138537+m-redding@users.noreply.github.com>
JoshLove-msft
approved these changes
Dec 5, 2023
haiyuazhang
pushed a commit
to haiyuazhang/azure-sdk-for-net
that referenced
this pull request
Mar 9, 2026
* Create base of release-sql-Microsoft.Sql-2025-02-01-preview via Copy-ApiVersion.ps1 (Azure#36370) * Copy files from preview/2024-11-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2025-02-01-preview Updated the API version from preview/2024-11-01-preview to preview/2025-02-01-preview. * Added tag for 2025-02-01-preview in readme file --------- Co-authored-by: Mitesh Vishwakarma <mvishwakarma@microsoft.com> * Swagger changes for Paginated List DDM rules API (Azure#36819) Co-authored-by: Santosh Padhy <santoshpadhy@microsoft.com> * Datasync UAMI support API in 2025-02-01-preview (Azure#35876) * Datasync UAMI support API in 2025-02-01-preview * Updated json to fix validation failure * Spell, lint fix * Fix error message * Updating error codes --------- Co-authored-by: Hareesh Kumar Gajulapalli <hgajulapalli@microsoft.com> * Azure SQL API Parity (Azure#38442) * Azure SQL API Parity * avocado error update * fixes lint diff errors --------- Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com> * Removing datasync breaking change because of required fields (Azure#39059) Co-authored-by: Hareesh Kumar Gajulapalli <hgajulapalli@microsoft.com> * Added back the legacy params (Azure#39317) Co-authored-by: Santosh Padhy <santoshpadhy@microsoft.com> * 20250201-preview breaking change fix for databases.json (Azure#40027) * breaking change fix * fix model validation failure --------- Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com> * fixing model validation errors (Azure#40364) * fixing model validation errors * adds model validation fix * fixes model validation errors * Fixes model validation errors * fixes model validation failures * model valdation fixes ' * model validation fix * model validation fixes * fixes model validation errors --------- Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com> * fix semantic error * fix semantic error * add v2 * fix breaking change (Azure#40593) Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com> * Adding suppressions previously approved in Azure#38470 (Azure#40764) * Removing the list import export operation results from Servers API (#40836) * Adding suppressions previously approved in Azure#38470 * Removing the list import export operation results from Servers API * Fix for lint-diff errors (Azure#40792) * Fix for lint-diff errors * Rectifies suppression for ResourceNamePattern * Remove ResourceNameRestriction validation code Removed ResourceNameRestriction code from parameters. * Fix formatting issue Fix formatting issue --------- Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com> Co-authored-by: Jeremy Frosti <111934615+jeremyfrosti@users.noreply.github.com> * Add suppression for ElasticPools to match existing suppression in Databases (Azure#40862) * Adding suppressions previously approved in Azure#38470 * Removing the list import export operation results from Servers API * Adding suppression for new currentSku in ElasticPool update --------- Co-authored-by: Mitesh Vishwakarma <mvishwakarma@microsoft.com> Co-authored-by: skpadhy33 <35034191+skpadhy33@users.noreply.github.com> Co-authored-by: Santosh Padhy <santoshpadhy@microsoft.com> Co-authored-by: hareeshghk <hareeshghk@users.noreply.github.com> Co-authored-by: Hareesh Kumar Gajulapalli <hgajulapalli@microsoft.com> Co-authored-by: zedy <zedy@wicresoft.com> Co-authored-by: Jeremy Frosti <111934615+jeremyfrosti@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to address a race condition where calling
IsRunningconcurrently with starting/stopping the processor could cause a semaphore to be double-released. As part of this fix, the approach used to detect when a semaphore should be released has been changed to consider the semaphore count rather than using a sentinel variable.Also fixed was an issue where the processor would leak a quota exceeded exception during startup validation if there were more than 4 other processors starting concurrently. The partition chosen for validation is now randomized and a quota exceeded response is now considered a successful validation.
References and Related