Skip to content

[AzureMonitorDistro] cleanup Integration Tests#36370

Merged
TimothyMothra merged 10 commits intomainfrom
tilee/update_integration_test
May 24, 2023
Merged

[AzureMonitorDistro] cleanup Integration Tests#36370
TimothyMothra merged 10 commits intomainfrom
tilee/update_integration_test

Conversation

@TimothyMothra
Copy link
Copy Markdown

@TimothyMothra TimothyMothra commented May 18, 2023

Fixes #36425

Changes

  • delete AzureMonitorTraceExporterLiveTests
    This was originally written to test the Exporter. Moving forward, we're going to do all of our Integration testing using the Distro.
    • also delete recordings
  • change DistroWebAppLiveTests to explicitly fail instead of using Assert.Inconclusive.
    The test host will report Inconclusive as a success. We need failures to be reported for further investigation.
  • change DistroWebAppLiveTests to SyncOnly. This is because The Async and Sync tests were running concurrently and failing.
  • update DistroWebAppLiveTests recordings.

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@TimothyMothra
Copy link
Copy Markdown
Author

TimothyMothra commented May 19, 2023

Investigating test failure.

MacOS + .NET7.0

Failed VerifyDistro [1 s]
  Error Message:
   System.InvalidOperationException : "The collection already contains item with same key 'sampleRate''"
  Stack Trace:
     at System.Diagnostics.ActivityTagsCollection.Add(String key, Object value)
   at OpenTelemetry.Trace.TracerProviderSdk.ComputeActivitySamplingResult(ActivityCreationOptions`1& options, Sampler sampler)
   at OpenTelemetry.Trace.TracerProviderSdk.<.ctor>b__10_4(ActivityCreationOptions`1& options)
   at System.Diagnostics.ActivitySource.<>c.<CreateActivity>b__18_1(ActivityListener listener, ActivityCreationOptions`1& data, ActivitySamplingResult& result, ActivityCreationOptions`1& unused)
   at System.Diagnostics.SynchronizedList`1.EnumWithFunc[TParent](Function`2 func, ActivityCreationOptions`1& data, ActivitySamplingResult& samplingResult, ActivityCreationOptions`1& dataWithContext)
   at System.Diagnostics.ActivitySource.CreateActivity(String name, ActivityKind kind, ActivityContext context, String parentId, IEnumerable`1 tags, IEnumerable`1 links, DateTimeOffset startTime, Boolean startIt, ActivityIdFormat idFormat)
   at System.Diagnostics.ActivitySource.CreateActivity(String name, ActivityKind kind)
   at System.Net.Http.DiagnosticsHandler.CreateActivity(HttpRequestMessage requestMessage)
   at System.Net.Http.DiagnosticsHandler.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.GetStringAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
   at Azure.Monitor.OpenTelemetry.AspNetCore.Integration.Tests.DistroWebAppLiveTests.VerifyDistro() in /Users/runner/work/1/s/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Integration.Tests/DistroWebAppLiveTests.cs:line 87
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.GetResult()
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__0()
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

--

Test failed 3 times in a row. I'm going to rebase this branch.

@TimothyMothra TimothyMothra force-pushed the tilee/update_integration_test branch from ce8b396 to 3057b4f Compare May 19, 2023 19:02
@TimothyMothra TimothyMothra marked this pull request as draft May 22, 2023 16:12
@TimothyMothra TimothyMothra marked this pull request as ready for review May 22, 2023 22:20
@TimothyMothra TimothyMothra merged commit b3dc8b4 into main May 24, 2023
@TimothyMothra TimothyMothra deleted the tilee/update_integration_test branch May 24, 2023 23:20
haiyuazhang pushed a commit to haiyuazhang/azure-sdk-for-net that referenced this pull request Mar 9, 2026
* Create base of release-sql-Microsoft.Sql-2025-02-01-preview via Copy-ApiVersion.ps1 (Azure#36370)

* Copy files from preview/2024-11-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-02-01-preview

Updated the API version from preview/2024-11-01-preview to preview/2025-02-01-preview.

* Added tag for 2025-02-01-preview in readme file

---------

Co-authored-by: Mitesh Vishwakarma <mvishwakarma@microsoft.com>

* Swagger changes for Paginated List DDM rules API (Azure#36819)

Co-authored-by: Santosh Padhy <santoshpadhy@microsoft.com>

* Datasync UAMI support API in 2025-02-01-preview (Azure#35876)

* Datasync UAMI support API in 2025-02-01-preview

* Updated json to fix validation failure

* Spell, lint fix

* Fix error message

* Updating error codes

---------

Co-authored-by: Hareesh Kumar Gajulapalli <hgajulapalli@microsoft.com>

* Azure SQL API Parity (Azure#38442)

* Azure SQL API Parity

* avocado error update

* fixes lint diff errors

---------

Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com>

* Removing datasync breaking change because of required fields (Azure#39059)

Co-authored-by: Hareesh Kumar Gajulapalli <hgajulapalli@microsoft.com>

* Added back the legacy params (Azure#39317)

Co-authored-by: Santosh Padhy <santoshpadhy@microsoft.com>

* 20250201-preview breaking change fix for databases.json (Azure#40027)

* breaking change fix

* fix model validation failure

---------

Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com>

* fixing model validation errors (Azure#40364)

* fixing model validation errors

* adds model validation fix

* fixes model validation errors

* Fixes model validation errors

* fixes model validation failures

* model valdation fixes '

* model validation fix

* model validation fixes

* fixes model validation errors

---------

Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com>

* fix semantic error

* fix semantic error

* add v2

* fix breaking change (Azure#40593)

Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com>

* Adding suppressions previously approved in Azure#38470 (Azure#40764)

* Removing the list import export operation results from Servers API (#40836)

* Adding suppressions previously approved in Azure#38470

* Removing the list import export operation results from Servers API

* Fix for lint-diff errors (Azure#40792)

* Fix for lint-diff errors

* Rectifies suppression for ResourceNamePattern

* Remove ResourceNameRestriction validation code

Removed ResourceNameRestriction code from parameters.

* Fix formatting issue

Fix formatting issue

---------

Co-authored-by: mvishwakarma <mvishwakarma@microsoft.com>
Co-authored-by: Jeremy Frosti <111934615+jeremyfrosti@users.noreply.github.com>

* Add suppression for ElasticPools to match existing suppression in Databases (Azure#40862)

* Adding suppressions previously approved in Azure#38470

* Removing the list import export operation results from Servers API

* Adding suppression for new currentSku in ElasticPool update

---------

Co-authored-by: Mitesh Vishwakarma <mvishwakarma@microsoft.com>
Co-authored-by: skpadhy33 <35034191+skpadhy33@users.noreply.github.com>
Co-authored-by: Santosh Padhy <santoshpadhy@microsoft.com>
Co-authored-by: hareeshghk <hareeshghk@users.noreply.github.com>
Co-authored-by: Hareesh Kumar Gajulapalli <hgajulapalli@microsoft.com>
Co-authored-by: zedy <zedy@wicresoft.com>
Co-authored-by: Jeremy Frosti <111934615+jeremyfrosti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Monitor - Distro Monitor OpenTelemetry Distro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Intermittent test failure in Azure.Monitor.OpenTelemetry.AspNetCore.Integration.Tests

3 participants