[CognitiveServices] LUIS Programmatic SDK#3987
[CognitiveServices] LUIS Programmatic SDK#3987shahabhijeet merged 5 commits intoAzure:psSdkJson6from
Conversation
shahabhijeet
left a comment
There was a problem hiding this comment.
For Azure.CognitiveServices.LUIS.csproj
- Add header/footer imports in the project file, include comments around the imports.
For CognitivieServices.Language.tests.csproj - Remove lines 10, 25-27
- Change < VersionPrefix > to < Version >
For Microsoft.Azure.CognitiveServices.Language.csproj
Model this project according to the comments given for other SDK proejcts.
Basically make test project and SDK projects similar to other data plane projects that are within cognitive services directory (take an example from search sdks)
| @@ -0,0 +1,17 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.reference.props'))" /> | |||
There was a problem hiding this comment.
@pcostantini include the comment around the imports of the project file similar to below
https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/CognitiveServices/dataPlane/Search/BingCustomSearch/BingCustomSearch/Microsoft.Azure.CognitiveServices.Search.CustomSearch.csproj#L2
Also include imports that are missing at the bottom of the project file.
| <PropertyGroup> | ||
| <PackageId>Microsoft.Azure.CognitiveServices.Language.LUIS.Programmatic</PackageId> | ||
| <Description>Provides API functions for consuming the Microsoft Azure Cognitive Services LUIS Programmatic API.</Description> | ||
| <VersionPrefix>2.0.0</VersionPrefix> |
There was a problem hiding this comment.
remove line 7,8 and replace < VersionPrefix to < Version >
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <TargetFramework>netcoreapp1.1</TargetFramework> | ||
| <IsPackable>false</IsPackable> |
| @@ -16,7 +16,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Include="..\LUIS-Runtime\Microsoft.Azure.CognitiveServices.LUIS.csproj" /> | |||
| <ProjectReference Include="..\Runtime\Microsoft.Azure.CognitiveServices.LUIS.csproj" /> | |||
There was a problem hiding this comment.
include the imports in LUIS.Tests project.
Remove lines 5,6
Remove lines 9-16 (all these references are implicitly added to each test project)
Add relevant properties about assemblyname, version etc to LUIS.Test project file (basically model this project file according to other test project files.
837ed63 to
65d633a
Compare
|
Hi @shahabhijeet, |
Based on the following Spec PRs:
This PR includes:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.