Skip to content

[CognitiveServices] LUIS Programmatic SDK#3987

Merged
shahabhijeet merged 5 commits intoAzure:psSdkJson6from
southworks:cognitiveservices-luis-programmatic-sdk
Jan 11, 2018
Merged

[CognitiveServices] LUIS Programmatic SDK#3987
shahabhijeet merged 5 commits intoAzure:psSdkJson6from
southworks:cognitiveservices-luis-programmatic-sdk

Conversation

@pcostantini
Copy link
Copy Markdown
Contributor

@pcostantini pcostantini commented Jan 9, 2018

Based on the following Spec PRs:

This PR includes:

  • C# Client for Programmatic API Endpoint generated with AutoRest (config)
  • API Token Credential
  • Unit Tests
  • Directory re-structure for CS Language SDKs

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Azure.CognitiveServices.LUIS.csproj

  1. Add header/footer imports in the project file, include comments around the imports.
    For CognitivieServices.Language.tests.csproj
  2. Remove lines 10, 25-27
  3. Change < VersionPrefix > to < Version >

For Microsoft.Azure.CognitiveServices.Language.csproj
Model this project according to the comments given for other SDK proejcts.
Basically make test project and SDK projects similar to other data plane projects that are within cognitive services directory (take an example from search sdks)

@@ -0,0 +1,17 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.reference.props'))" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<PropertyGroup>
<PackageId>Microsoft.Azure.CognitiveServices.Language.LUIS.Programmatic</PackageId>
<Description>Provides API functions for consuming the Microsoft Azure Cognitive Services LUIS Programmatic API.</Description>
<VersionPrefix>2.0.0</VersionPrefix>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove line 7,8 and replace < VersionPrefix to < Version >

</PropertyGroup>
<PropertyGroup>
<TargetFramework>netcoreapp1.1</TargetFramework>
<IsPackable>false</IsPackable>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove line 10

@@ -16,7 +16,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\LUIS-Runtime\Microsoft.Azure.CognitiveServices.LUIS.csproj" />
<ProjectReference Include="..\Runtime\Microsoft.Azure.CognitiveServices.LUIS.csproj" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include the imports in LUIS.Tests project.
Remove lines 5,6
Remove lines 9-16 (all these references are implicitly added to each test project)
Add relevant properties about assemblyname, version etc to LUIS.Test project file (basically model this project file according to other test project files.

@pcostantini pcostantini force-pushed the cognitiveservices-luis-programmatic-sdk branch from 837ed63 to 65d633a Compare January 10, 2018 17:56
@pcostantini
Copy link
Copy Markdown
Contributor Author

Hi @shahabhijeet,
Feedback was applied. Let me know if there is anything else we should look into.
Regards,
-PabloC.

@shahabhijeet shahabhijeet merged commit 30aad61 into Azure:psSdkJson6 Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants