Skip to content

[CognitiveServices] LUIS SDKs directory re-structure#2214

Merged
marstr merged 1 commit intoAzure:masterfrom
southworks:cognitiveservices-language-directory-restructure
Jan 5, 2018
Merged

[CognitiveServices] LUIS SDKs directory re-structure#2214
marstr merged 1 commit intoAzure:masterfrom
southworks:cognitiveservices-language-directory-restructure

Conversation

@pcostantini
Copy link
Copy Markdown
Contributor

@pcostantini pcostantini commented Jan 4, 2018 •
edited by azuresdkci
Loading

Update C# SDK folder output based on PR feedback: Azure/azure-sdk-for-net#3946

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Jan 4, 2018

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/cognitiveservices/data-plane/LUIS/Programmatic/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/LUIS/Runtime/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@pcostantini pcostantini changed the base branch from master to current January 4, 2018 23:07
@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Jan 5, 2018

Please reopen the PR against master since we are moving all PRs there.
@marstr please confirm

@pcostantini pcostantini changed the base branch from current to master January 5, 2018 01:30
@pcostantini
Copy link
Copy Markdown
Contributor Author

pcostantini commented Jan 5, 2018 •
edited
Loading

Hi @dsgouda ,
The PR is now updated against master
Thanks,
-PabloC.

dsgouda
dsgouda approved these changes Jan 5, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marstr
Copy link
Copy Markdown
Member

marstr commented Jan 5, 2018

Committing for @dsgouda because of some permission errors :)

@marstr marstr merged commit 9cacecc into Azure:master Jan 5, 2018
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jan 5, 2018

No modification for AutorestCI/azure-sdk-for-ruby

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jan 5, 2018

No modification for AutorestCI/azure-sdk-for-python

1 similar comment
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jan 5, 2018

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jan 5, 2018

No modification for AutorestCI/azure-sdk-for-ruby

@pcostantini pcostantini mentioned this pull request Jan 9, 2018
Merged
9 tasks
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@abatishchev
Fixed typo in deviceupdate.json (#2214)
2a98559 
* Update deviceupdate.json

* Update deviceupdate.json

* Update deviceupdate.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsgouda dsgouda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pcostantini @azuresdkciprbot @dsgouda @marstr @AutorestCI