[CognitiveServices] LUIS Programmatic API Spec by pcostantini · Pull Request #2083 · Azure/azure-rest-api-specs

pcostantini · 2017-12-02T02:17:29Z

This PR includes the API Spec for the LUIS Runtime endpoint (Predictions):
https://westus.dev.cognitive.microsoft.com/docs/services/5890b47c39e2bb17b84a55ff/operations/5890b47c39e2bb052c5b9c2f

The whole the spec has been reviewed and updated.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

- Swagger Spec + Samples - Readme with C# generation configuration

…thub.com/southworkscom/azure-rest-api-specs into cognitiveservices-luis-programmatic-spec

…:southworkscom/azure-rest-api-specs into cognitiveservices-luis-programmatic-spec

…thub.com/southworkscom/azure-rest-api-specs into cognitiveservices-luis-programmatic-spec

…tityModel updated

…tps://github.com/southworkscom/azure-rest-api-specs into cognitiveservices-luis-programmatic-spec-current

…tic-spec-current' into cognitiveservices-luis-programmatic-spec

alvadb · 2017-12-09T06:14:14Z

+          "200": {
+            "description": "If there's no trained model, nothing is returned in the response. If there's a trained model and the active learning algorithm finds any relevant queries, they are returned with the model predictions. If there's a trained model but the active learning algorithm didn't find any relevant queries, an empty list is returned in the response.",
+            "schema": {
+


Please add description to properties.

alvadb · 2017-12-09T06:14:33Z

+          "200": {
+            "description": "If there's no trained model, nothing is returned in the response. If there's a trained model and the active learning algorithm finds any relevant queries, they are returned with the model predictions. If there's a trained model but the active learning algorithm didn't find any relevant queries, an empty list is returned in the response.",
+            "schema": {
+


Please add description for properties.

alvadb · 2017-12-09T06:15:53Z

+          "200": {
+            "description": "If there's no trained model, nothing is returned in the response. If there's a trained model and the active learning algorithm finds any relevant queries, they are returned with the model predictions. If there's a trained model but the active learning algorithm didn't find any relevant queries, an empty list is returned in the response.",
+            "schema": {
+


Please add description to properties.

alvadb · 2017-12-09T06:25:43Z

+          "200": {
+            "description": "If there's no trained model, nothing is returned in the response. If there's a trained model and the active learning algorithm finds any relevant queries, they are returned with the model predictions. If there's a trained model but the active learning algorithm didn't find any relevant queries, an empty list is returned in the response.",
+            "schema": {
+


Please add description to properties.

alvadb · 2017-12-09T07:02:29Z

Please review and fix linter and model errors:
linter: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/313223806
model: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/313223807

enzocano · 2017-12-11T20:12:12Z

Hi @alvadb

We reviewed the lint errors and fixed almost all of them.
The followings autorest-lint errors are related to the current implementation of LUIS API and cannot be addressed without introducing breaking changes to the current live API:

Delete operations with request body (DeleteMustNotHaveRequestBody error)
Both operations use the request body to specify the entity to delete
Properties not using camelCase style (DefinitionsPropertiesNamesCamelCase error)
All these properties are defined as-is from the LUIS API and cannot be changed in the Swagger without updating the API implementation

Regards,
-EnzoC.

azuresdkciprbot · 2017-12-12T13:41:09Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/cognitiveservices/data-plane/LUIS/Programmatic/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

… API

azuresdkciprbot · 2017-12-12T13:58:57Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/cognitiveservices/data-plane/LUIS/Programmatic/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2017-12-13T06:49:16Z

No modification for AutorestCI/azure-sdk-for-python

AutorestCI · 2017-12-13T06:49:20Z

No modification for AutorestCI/azure-sdk-for-ruby

pcostantini and others added 30 commits November 27, 2017 16:19

LUIS Programmatic API (v2.0) - Initial commit

b478460

- Swagger Spec + Samples - Readme with C# generation configuration

Add example for App_AddCustomPrebuiltApplication op

b9d3779

Fix example for Permissions_GetApplicationUserAccessList op

449ee5d

Remove unsupported x-ms-nullable from ModelTrainingDetails.failureReason

115bbdf

Add example for Permissions_AddUserToAccessList op

2980276

Merge branch 'cognitiveservices-luis-programmatic-spec' of https://gi…

a9336ee

…thub.com/southworkscom/azure-rest-api-specs into cognitiveservices-luis-programmatic-spec

Add example for Apps_DeleteApplication op

8c4f52c

Fix sample for Permissions_RemoveUserFromAccessList op

a18fcb3

Fix Apps_GetEndpoints example

4fa6e48

Add example for Permissions_UpdateAccessList

542dfd4

Update Apps_PublishApplication definition and samples

ee82bf9

Apps_GetApplicationSettings fix to definition and sample

8635f4b

Apps_GetApplicationSettings return type fix

26b25b8

Merge branch 'cognitiveservices-luis-programmatic-spec' of github.com…

d2d227e

…:southworkscom/azure-rest-api-specs into cognitiveservices-luis-programmatic-spec

Casing fix

15916c3

Apps_UpdateApplicationSettings definition and sample fixes

51c1e00

Add example for Versions_GetApplicationVersions op

dae9334

Merge branch 'cognitiveservices-luis-programmatic-spec' of https://gi…

52038f9

…thub.com/southworkscom/azure-rest-api-specs into cognitiveservices-luis-programmatic-spec

Remove x-nullable: true

36d2ce5

Add example for Versions_GetApplicationVersion op

3bd676e

Add example for Versions_RenameApplicationVersion op

c930a5a

Add example for Versions_DeleteApplicationVersion op

d6adc0d

Add example for Versions_CloneVersion op

2aef9fa

Delete subscriptionKey operations

a3e1e6f

Add example for Model_AddCustomPrebuiltDomainToApplication op

f940472

Add example for Model_DeleteCustomPrebuiltDomainModels op

fc88e50

WIP

27aec79

Model_GetApplicationVersionClosedListInfos & Model_CreateClosedListEn…

dbedc87

…tityModel updated

Model_GetClosedListEntityInfo sample update

239a7b1

Model_UpdateClosedListEntityModel updated and sample

56fc985

pcostantini added 3 commits December 4, 2017 18:32

Deprecation notice for Pattern operations

88fcc5e

Deprecation directive for Pattern operations

21968eb

Deprecation attribute for Pattern operations

eebd03e

pcostantini force-pushed the cognitiveservices-luis-programmatic-spec branch from 1f60e35 to d0cb2bb Compare December 5, 2017 13:39

Ignore Autorest-linter issues that require breaking changes to API

04b7234

pcostantini force-pushed the cognitiveservices-luis-programmatic-spec branch from d0cb2bb to 04b7234 Compare December 5, 2017 13:44

enzocano and others added 7 commits December 5, 2017 11:32

Update ErrorResponse definitions

10eddb1

Update ErrorResponse definitions

0b5cd69

Merge branch 'cognitiveservices-luis-programmatic-spec-current' of ht…

d8259e5

…tps://github.com/southworkscom/azure-rest-api-specs into cognitiveservices-luis-programmatic-spec-current

Add missing descriptions and cleanup unused models

4dbab57

Merge remote-tracking branch 'origin/cognitiveservices-luis-programma…

701ae5b

…tic-spec-current' into cognitiveservices-luis-programmatic-spec

required fields for EntityLabel/Prediction

fe9fb31

LUIS Programmatic API - README fixes

66579df

pcostantini force-pushed the cognitiveservices-luis-programmatic-spec branch from eb066f5 to 66579df Compare December 7, 2017 23:09

alvadb suggested changes Dec 9, 2017

View reviewed changes

stevengum mentioned this pull request Dec 9, 2017

Performed changes according to feedback on Azure/azure-rest-api-specs/pull/1833 omarelhariry137/azure-rest-api-specs#1

Closed

9 tasks

enzocano added 2 commits December 11, 2017 14:38

Fix aov model examples mismatched

356b3cc

Delete AutoRest-Linter Supressions

5cd298a

Suppress Autorest-linter issues that require breaking changes to LUIS…

898921e

… API

enzocano force-pushed the cognitiveservices-luis-programmatic-spec branch from 372d803 to 898921e Compare December 12, 2017 13:54

alvadb approved these changes Dec 13, 2017

View reviewed changes

alvadb merged commit 2e03dc2 into Azure:current Dec 13, 2017

JuanAr mentioned this pull request Dec 13, 2017

[CognitiveServices] LUIS Programmatic SDK - Updates based on latest Spec Azure/azure-sdk-for-net#3946

Closed

9 tasks

pcostantini mentioned this pull request Jan 9, 2018

[CognitiveServices] LUIS Programmatic SDK Azure/azure-sdk-for-net#3987

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CognitiveServices] LUIS Programmatic API Spec#2083

[CognitiveServices] LUIS Programmatic API Spec#2083
alvadb merged 134 commits intoAzure:currentfrom
southworks:cognitiveservices-luis-programmatic-spec

pcostantini commented Dec 2, 2017 •

edited

Loading

Uh oh!

alvadb Dec 9, 2017

Uh oh!

alvadb Dec 9, 2017

Uh oh!

alvadb Dec 9, 2017

Uh oh!

alvadb Dec 9, 2017

Uh oh!

alvadb commented Dec 9, 2017

Uh oh!

enzocano commented Dec 11, 2017

Uh oh!

azuresdkciprbot commented Dec 12, 2017

Uh oh!

azuresdkciprbot commented Dec 12, 2017

Uh oh!

AutorestCI commented Dec 13, 2017

Uh oh!

AutorestCI commented Dec 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

pcostantini commented Dec 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

alvadb Dec 9, 2017

Choose a reason for hiding this comment

Uh oh!

alvadb Dec 9, 2017

Choose a reason for hiding this comment

Uh oh!

alvadb Dec 9, 2017

Choose a reason for hiding this comment

Uh oh!

alvadb Dec 9, 2017

Choose a reason for hiding this comment

Uh oh!

alvadb commented Dec 9, 2017

Uh oh!

enzocano commented Dec 11, 2017

Uh oh!

azuresdkciprbot commented Dec 12, 2017

Uh oh!

azuresdkciprbot commented Dec 12, 2017

Uh oh!

AutorestCI commented Dec 13, 2017

Uh oh!

AutorestCI commented Dec 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pcostantini commented Dec 2, 2017 •

edited

Loading