[ADLA] - Adding Scope APIs/Properties, existing Catalog APIs, and existing Account APIs#3960
Merged
shahabhijeet merged 14 commits intoAzure:psSdkJson6from Jan 4, 2018
Merged
Conversation
9 tasks
b6f5eb5 to
7125c99
Compare
shahabhijeet
suggested changes
Jan 3, 2018
Contributor
There was a problem hiding this comment.
- Get latest updates from upstream (if you have not done so in last 3 weeks)
- Then execute msbuild build.proj to update your build tools
- Then regenerate your SDK (this will regenerate couple of additional files, this file is required and usually starts with SDK_*.cs
- build you project (ether IDE or command line, this will create addition file *.props. This file is also reqired)
- Then update your PR
With the latest changes, every regeneration will generate couple of additional meta data files that are needed in each PR.
Contributor
Author
|
@shahabhijeet I followed those steps already as you noted them in my initial PR: #3954 I did notice one extra file being generated when I built the project using the IDE, which I did not include here |
Contributor
|
@ro-joowan those files required. See my previous comment where I specified which step will create which file and all those files are required. |
Forgot about resource-manager code gen
It looks like the props file wasn't fully updated, so I ran msbuild build.proj again before building the project via the IDE
Contributor
Author
|
@shahabhijeet Thank you pointing them out in detail! The process makes more sense now. I have updated this PR. |
Contributor
Author
|
@shahabhijeet Not sure why Travis failed, is there a way to restart? |
shahabhijeet
approved these changes
Jan 4, 2018
Contributor
shahabhijeet
left a comment
There was a problem hiding this comment.
This PR looks good, once the CI passes this is good to be merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REST spec PR link to the SDK PR
[ADLA] Changes in 3.2.3-preview
Breaking changes
ODataQueryparameter type fromDataLakeAnalyticsAccounttoDataLakeAnalyticsAccountBasicfor these APIs:USqlJobProperties, fixed the property name ofTotalPauseTimetoTotalPausedTimeNotes
JobStatisticsVertexStageDataLakeAnalyticsAccountStatusenum:UndeletingandCanceledDescription
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.