Skip to content

[ADLA] - Adding Scope APIs/Properties, existing Catalog APIs, and existing Account APIs#3960

Merged
shahabhijeet merged 14 commits intoAzure:psSdkJson6from
ro-joowan:scope-adla
Jan 4, 2018
Merged

[ADLA] - Adding Scope APIs/Properties, existing Catalog APIs, and existing Account APIs#3960
shahabhijeet merged 14 commits intoAzure:psSdkJson6from
ro-joowan:scope-adla

Conversation

@ro-joowan
Copy link
Copy Markdown
Contributor

@ro-joowan ro-joowan commented Dec 18, 2017

  • I did not add unit tests for anything related to Scope. These APIs/properties are for internal use only, as noted in their descriptions, and we have internal tests for them.

REST spec PR link to the SDK PR

[ADLA] Changes in 3.2.3-preview

Breaking changes

  • Changed the ODataQuery parameter type from DataLakeAnalyticsAccount to DataLakeAnalyticsAccountBasic for these APIs:
    • Account_List
    • Account_ListByResourceGroup
  • For USqlJobProperties, fixed the property name of TotalPauseTime to TotalPausedTime

Notes

  • Added more properties to JobStatisticsVertexStage
  • Added two more states to DataLakeAnalyticsAccountStatus enum: Undeleting and Canceled
  • Added new Account APIs:
    • Account_CheckNameAvailability
    • Location_GetCapability
    • Operation_List
  • Added new Catalog APIs:
    • Catalog_ListAclsByDatabase
    • Catalog_ListAcls
    • Catalog_GrantAclToDatabase
    • Catalog_RevokeAclFromDatabase
    • Catalog_GrantAcl
    • Catalog_RevokeAcl

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@ro-joowan ro-joowan changed the title [ADLA] - Adding Scope APIs/Properties and other revisions/bugfixes [ADLA] - Adding Scope APIs/Properties, existing Catalog APIs, and existing Account APIs Dec 21, 2017
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Get latest updates from upstream (if you have not done so in last 3 weeks)
  2. Then execute msbuild build.proj to update your build tools
  3. Then regenerate your SDK (this will regenerate couple of additional files, this file is required and usually starts with SDK_*.cs
  4. build you project (ether IDE or command line, this will create addition file *.props. This file is also reqired)
  5. Then update your PR
    With the latest changes, every regeneration will generate couple of additional meta data files that are needed in each PR.

@ro-joowan
Copy link
Copy Markdown
Contributor Author

ro-joowan commented Jan 3, 2018

@shahabhijeet I followed those steps already as you noted them in my initial PR: #3954

I did notice one extra file being generated when I built the project using the IDE, which I did not include here

@shahabhijeet
Copy link
Copy Markdown
Contributor

@ro-joowan those files required. See my previous comment where I specified which step will create which file and all those files are required.

Forgot about resource-manager code gen
It looks like the props file wasn't fully updated, so I ran msbuild
build.proj again before building the project via the IDE
@ro-joowan
Copy link
Copy Markdown
Contributor Author

@shahabhijeet Thank you pointing them out in detail! The process makes more sense now. I have updated this PR.

@ro-joowan
Copy link
Copy Markdown
Contributor Author

@shahabhijeet Not sure why Travis failed, is there a way to restart?

Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, once the CI passes this is good to be merged

@shahabhijeet shahabhijeet merged commit 499c6d8 into Azure:psSdkJson6 Jan 4, 2018
@ro-joowan ro-joowan deleted the scope-adla branch January 5, 2018 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants