Skip to content

[ADLA] - Adding existing Catalog ACL APIs#1952

Merged
jianghaolu merged 6 commits intoAzure:currentfrom
ro-joowan:existing-catalog-acl-apis
Nov 6, 2017
Merged

[ADLA] - Adding existing Catalog ACL APIs#1952
jianghaolu merged 6 commits intoAzure:currentfrom
ro-joowan:existing-catalog-acl-apis

Conversation

@ro-joowan
Copy link
Copy Markdown
Contributor

@ro-joowan ro-joowan commented Oct 31, 2017 •
edited by azuresdkci
Loading

  • Adding six existing ACL APIs for Catalog -- thus this PR is to fill in the missing gap.

  • Since they were existing, we could not give feedback about the usage of OP to define the call. We will work on possibly removing this and redesigning it in a new API version for Catalog, which is in progress.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@ro-joowan
[CODE] - Adding ACL APIs
d0bcc54
@ro-joowan
[FILE] - Adding example files
be683ac
@ro-joowan
[CODE] - Putting GRANTACE and REVOKE APIs uner x-ms-paths
7d27548 
* This is to follow the guidelines about having multiple paths with the
same definition but with different query parameters
@ro-joowan
[CODE] - Removing paging for ListAcl APIs
109347c 
* This is not supported
@ro-joowan
[CODE] - Revising descriptions
f98f326
@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Oct 31, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datalake-analytics/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jianghaolu
jianghaolu suggested changes Nov 1, 2017
View reviewed changes
specification/datalake-analytics/data-plane/Microsoft.DataLakeAnalytics/2016-11-01/catalog.json Outdated
"$ref": "#/definitions/AclList"
}
},
"404": {
Copy link
Copy Markdown
Contributor

@jianghaolu jianghaolu Nov 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the negative response status code descriptions MUST be defined in the description of the "default" status code (if the intention is for documentation purpose only). Example: "description": "'404' - 'Not found'.\n'400' - 'Bad request'.\n'500': 'Internal Server Error'."'

Copy link
Copy Markdown
Contributor

@jianghaolu jianghaolu Nov 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for elsewhere.

Copy link
Copy Markdown
Contributor Author

@ro-joowan ro-joowan Nov 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jianghaolu! Fixed it, but let me know if I need to add the single quotes.

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Nov 3, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datalake-analytics/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@jianghaolu jianghaolu merged commit 0f3a5c9 into Azure:current Nov 6, 2017
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Nov 6, 2017

No modification for AutorestCI/azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Nov 6, 2017
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Nov 6, 2017

Build Status Azure/azure-sdk-for-python#1608

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Nov 6, 2017

No modification for AutorestCI/azure-sdk-for-node

@ro-joowan ro-joowan deleted the existing-catalog-acl-apis branch November 8, 2017 01:41
This was referenced Dec 15, 2017
Closed
Merged
Merged
@idear1203 idear1203 mentioned this pull request May 18, 2018
Merged
8 tasks
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@bindup-ms
New API version for Microsoft.Falcon (#1952)
f18b0e7 
* Optional serviceName property in namespace properties

* New API version to introduce optional parameter

* Fix Swagger error

* Fix Swagger error

* Fix ListFalconOperations.json

* Fix readme.md

* Add default response to Patch operation

* Add openapi-subtype

* Update readme files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jianghaolu jianghaolu jianghaolu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jianghaolu jianghaolu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ro-joowan @azuresdkciprbot @AutorestCI @jianghaolu