Skip to content

[ADLA - ADLS] - [BUGFIX] - Fixing x-ms-odata parameters#1857

Merged
veronicagg merged 2 commits intoAzure:currentfrom
ro-joowan:bugfix-odata-objects
Oct 17, 2017
Merged

[ADLA - ADLS] - [BUGFIX] - Fixing x-ms-odata parameters#1857
veronicagg merged 2 commits intoAzure:currentfrom
ro-joowan:bugfix-odata-objects

Conversation

@ro-joowan
Copy link
Copy Markdown
Contributor

@ro-joowan ro-joowan commented Oct 12, 2017

  • These x-ms-odata parameters were not updated in a prior PR

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datalake-analytics/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datalake-analytics/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/datalake-store/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Copy link
Copy Markdown
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ro-joowan . Is there an issue associated with this bug fix?
Change itself looks good to me.

@ro-joowan
Copy link
Copy Markdown
Contributor Author

@veronicagg There is no issue associated with this. Thank you!

@veronicagg
Copy link
Copy Markdown
Contributor

@ro-joowan ok, how did you figure out there was an issue? Next time I'd recommend opening one.

@ro-joowan
Copy link
Copy Markdown
Contributor Author

@veronicagg Good question :) -- I was working on new APIs for catalog.json that involved x-ms-odata, and it occurred to me that this wasn't addressed in a previous/recent work for job.json/account.json

@ro-joowan
Copy link
Copy Markdown
Contributor Author

@veronicagg I'll keep the idea of issues in mind next time

@veronicagg
Copy link
Copy Markdown
Contributor

@ro-joowan ok, since the model is changing for the odata extension, it may cause a breaking change in some of the generated code, have you checked any of the SDKs? are you ok with that?

@ro-joowan
Copy link
Copy Markdown
Contributor Author

@veronicagg Thanks for noting this. I am okay with this breaking change because this is technically a bugfix. That is, the server hasn't been returning the extra fields in JobInformation that are not in JobInformationBasic, and so I cannot imagine this having a considerable impact as a breaking change.

* For "runs" and "recurrences" properties of JobPipelineInformation
@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datalake-analytics/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/datalake-analytics/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

File: specification/datalake-store/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 6
After the PR: Warning(s): 0 Error(s): 6

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Copy link
Copy Markdown
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@veronicagg veronicagg merged commit ee6f9fc into Azure:current Oct 17, 2017
@AutorestCI
Copy link
Copy Markdown

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

@AutorestCI
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants