[ADLA - ADLS] - [BUGFIX] - Fixing x-ms-odata parameters#1857
[ADLA - ADLS] - [BUGFIX] - Fixing x-ms-odata parameters#1857veronicagg merged 2 commits intoAzure:currentfrom
Conversation
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: File: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
veronicagg
left a comment
There was a problem hiding this comment.
thanks @ro-joowan . Is there an issue associated with this bug fix?
Change itself looks good to me.
|
@veronicagg There is no issue associated with this. Thank you! |
|
@ro-joowan ok, how did you figure out there was an issue? Next time I'd recommend opening one. |
|
@veronicagg Good question :) -- I was working on new APIs for catalog.json that involved x-ms-odata, and it occurred to me that this wasn't addressed in a previous/recent work for job.json/account.json |
|
@veronicagg I'll keep the idea of issues in mind next time |
|
@ro-joowan ok, since the model is changing for the odata extension, it may cause a breaking change in some of the generated code, have you checked any of the SDKs? are you ok with that? |
|
@veronicagg Thanks for noting this. I am okay with this breaking change because this is technically a bugfix. That is, the server hasn't been returning the extra fields in JobInformation that are not in JobInformationBasic, and so I cannot imagine this having a considerable impact as a breaking change. |
* For "runs" and "recurrences" properties of JobPipelineInformation
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: File: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
No modification for AutorestCI/azure-sdk-for-node |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger