[Search] Implementation of GA Features for API Version 23-11-01#39305
Merged
ShivangiReja merged 32 commits intoAzure:feature/ShivangiReja/search2023-11-01from Nov 2, 2023
Merged
Conversation
ShivangiReja
requested review from
a team,
KrzysztofCwalina,
heaths,
kinelski and
tg-msft
as code owners
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
heaths
requested changes
Oct 25, 2023
sdk/search/Azure.Search.Documents/samples/Sample07_VectorSearch_UsingFieldBuilder.md
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/samples/Sample08_SemanticSearch.md
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/samples/Sample08_SemanticSearch.md
Outdated
Show resolved
Hide resolved
ShivangiReja
commented
Oct 25, 2023
sdk/search/Azure.Search.Documents/api/Azure.Search.Documents.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/src/Indexes/Models/AnalyzeTextOptions.cs
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/src/Indexes/Models/PiiDetectionSkill.cs
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/src/Indexes/Models/VectorSearchField.cs
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/src/Indexes/Models/EntityRecognitionSkill.SkillVersion.cs
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/src/Indexes/VectorSearchFieldAttribute.cs
Outdated
Show resolved
Hide resolved
ShivangiReja
commented
Oct 26, 2023
sdk/search/Azure.Search.Documents/src/Indexes/Models/VectorSearchField.cs
Show resolved
Hide resolved
tg-msft
approved these changes
Oct 27, 2023
Member
tg-msft
left a comment
tg-msft
left a comment
There was a problem hiding this comment.
I love how clean this looks!!! Awesome job.
sdk/search/Azure.Search.Documents/samples/Sample07_VectorSearch_UsingVectorQuery.md
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/samples/Sample07_VectorSearch_UsingVectorQuery.md
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/samples/Sample08_SemanticSearch.md
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/src/Indexes/Models/AnalyzeTextOptions.cs
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/src/Indexes/Models/PiiDetectionSkill.cs
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/src/Options/SemanticSearchOptions.cs
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/src/Options/SemanticSearchOptions.cs
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/src/Options/VectorSearchOptions.cs
Outdated
Show resolved
Hide resolved
heaths
approved these changes
Oct 27, 2023
6 tasks
…b.com/Azure/azure-sdk-for-net into Implement_SearchGA-2023-11-01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes code regeneration based on the 23-11-01 GA Swagger specification found at Azure/azure-rest-api-specs@d52c50c.