Skip to content

Adding ReadOnlyMemory support#3875

Merged
m-nash merged 8 commits intofeature/v3from
mnash-readOnlyMemory
Oct 31, 2023
Merged

Adding ReadOnlyMemory support#3875
m-nash merged 8 commits intofeature/v3from
mnash-readOnlyMemory

Conversation

@m-nash
Copy link
Copy Markdown
Member

@m-nash m-nash commented Oct 28, 2023 •
edited
Loading

Description

Addresses this comment Azure/azure-sdk-for-net#39305 (comment)

Adds support for ReadOnlyMemory

For swagger you can use "x-ms-embedding-vectory": true
For tsp you will need to customize the property type, but the generator should handle serialization / initialization for you. Azure/typespec-azure#3781

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@m-nash m-nash mentioned this pull request Oct 28, 2023
Merged
@m-nash m-nash changed the title wip adding ReadOnlyMemory Adding ReadOnlyMemory support Oct 28, 2023
@azure-sdk azure-sdk mentioned this pull request Oct 28, 2023
Closed
@m-nash m-nash marked this pull request as ready for review October 29, 2023 00:02
@lirenhe lirenhe added the DPG label Oct 31, 2023
jsquire
jsquire approved these changes Oct 31, 2023
View reviewed changes
@m-nash @jsquire
Update src/AutoRest.CSharp/Common/Generation/Writers/FormattableStrin…
a91c426 
…gHelpers.cs

Co-authored-by: Jesse Squire <jsquire@microsoft.com>
@azure-sdk azure-sdk mentioned this pull request Oct 31, 2023
Closed
@m-nash m-nash enabled auto-merge (squash) October 31, 2023 19:12
@m-nash
Copy link
Copy Markdown
Member Author

m-nash commented Oct 31, 2023

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 31, 2023

Azure Pipelines successfully started running 2 pipeline(s).

@m-nash m-nash merged commit b1199d5 into feature/v3 Oct 31, 2023
@m-nash m-nash deleted the mnash-readOnlyMemory branch October 31, 2023 21:23
live1206 pushed a commit to live1206/autorest.csharp that referenced this pull request Dec 11, 2023
@m-nash @jsquire @live1206
Adding ReadOnlyMemory support (Azure#3875)
466100e 
* wip adding ReadOnlyMemory

* finish adding embedding vector support for swagger

* add ability for customization of embedding vector in tsp path

* update tests

* address feedback

* address more feedback

* Update src/AutoRest.CSharp/Common/Generation/Writers/FormattableStringHelpers.cs

Co-authored-by: Jesse Squire <jsquire@microsoft.com>

---------

Co-authored-by: Jesse Squire <jsquire@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang left review comments

@jsquire jsquire jsquire approved these changes

@lirenhe lirenhe Awaiting requested review from lirenhe

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978

@hallipr hallipr Awaiting requested review from hallipr

+1 more reviewer

@AlexanderSher AlexanderSher AlexanderSher left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DPG

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@m-nash @jsquire @AlexanderSher @ArcturusZhang @lirenhe