Skip to content

[Search] Implementation of GA Features for API Version 23-11-01#39265

Closed
ShivangiReja wants to merge 5 commits intoAzure:SearchGA-2023-11-01from
ShivangiReja:Implement_SearchGA-2023-11-01
Closed

[Search] Implementation of GA Features for API Version 23-11-01#39265
ShivangiReja wants to merge 5 commits intoAzure:SearchGA-2023-11-01from
ShivangiReja:Implement_SearchGA-2023-11-01

Conversation

@ShivangiReja
Copy link
Copy Markdown
Member

This PR includes code regeneration based on the 23-11-01 GA Swagger specification found at Azure/azure-rest-api-specs@d52c50c.

@ShivangiReja ShivangiReja changed the title [Draft][Search] Implementation of GA Features for API Version 23-11-01 [Search] Implementation of GA Features for API Version 23-11-01 Oct 13, 2023
@ShivangiReja ShivangiReja marked this pull request as ready for review October 13, 2023 17:07
/// </summary>
V2023_10_01_Preview = 3,
#pragma warning restore CA1707
V2023_11_01 = 2,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for @tg-msft as I don't know the handling in .NET too well.

Once the GA is released and we go back to preview development in main V2023_10_01_Preview will be = 3, correct? There's no requirement that the enum values sort lexically, right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct. When we GA we collapse out any previews and we'll keep incrementing the version numbers when we add the new preview back. The way it plays out in this case is unfortunate but necessary given the service's behavior.

@ShivangiReja ShivangiReja deleted the branch Azure:SearchGA-2023-11-01 October 16, 2023 18:32
@ShivangiReja
Copy link
Copy Markdown
Member Author

This PR has been moved here - #39305

haiyuazhang pushed a commit to haiyuazhang/azure-sdk-for-net that referenced this pull request Mar 8, 2026
* Rename body

* update examples.

* updates

* update

* update

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants