Adding .NET SDK changes for Server DNS Aliasing by maboja-msft · Pull Request #3803 · Azure/azure-sdk-for-net

maboja-msft · 2017-10-19T03:38:01Z

This main aim of this change is to add .NET SDK changes for Server DNS Aliasing. While generating them from latest swagger, several files got updated with removing unused declarations.

Swagger pull request link: Azure/azure-rest-api-specs#1858

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

…ins removing unused declarations from bunch of files. Everything generated automatically

maboja-msft · 2017-10-19T03:50:00Z

@jaredmoo I will greatly appreciate comments on those changes

jaredmoo

Overall looks good, minor comments.

jaredmoo · 2017-10-19T05:25:48Z

src/SDKs/SqlManagement/Management.Sql/Properties/AssemblyInfo.cs

 [assembly: AssemblyDescription("Provides management functionality for Microsoft Azure SQL.")]
 [assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyFileVersion("1.8.0.0")]
+[assembly: AssemblyFileVersion("1.9.0.0")]


please revert, 1.8.0 has not yet been published ( see https://www.nuget.org/packages/Microsoft.Azure.Management.Sql )

jaredmoo · 2017-10-19T05:26:19Z

src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj

    <Description>Azure SQL Management SDK library</Description>
    <AssemblyName>Microsoft.Azure.Management.Sql</AssemblyName>
-    <VersionPrefix>1.8.0-preview</VersionPrefix>
+    <VersionPrefix>1.9.0-preview</VersionPrefix>


Please revert

jaredmoo · 2017-10-19T05:27:09Z

src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj

+    <VersionPrefix>1.9.0-preview</VersionPrefix>
    <PackageTags>Microsoft Azure SQL Management;SQL;SQL Management</PackageTags>
  </PropertyGroup>
  <PropertyGroup>


please add a release note in <PackageReleaseNotes> below, e.g. 'Added support for server dns aliases'.

jaredmoo · 2017-10-19T05:29:31Z

src/SDKs/SqlManagement/Sql.Tests/ServerDnsAliasCrudScenarioTests.cs

+
+                // Update server to which alias is pointing
+                //
+                var serverDnsAliasAcquisitonParams = new ServerDnsAliasAcquisition(String.Format("/subscriptions/{0}/resourceGroups/{1}/providers/Microsoft.Sql/servers/{2}/dnsAliases/{3}", sqlClient.SubscriptionId, resourceGroup.Name, sourceServer.Name, serverDnsAliasName));


nit: long line, can you split over multiple lines

var serverDnsAliasAcquisitonParams = new ServerDnsAliasAcquisition( string.Format( "/subscriptions/{0}/resourceGroups/{1}/providers/Microsoft.Sql/servers/{2}/dnsAliases/{3}", sqlClient.SubscriptionId, resourceGroup.Name, sourceServer.Name, serverDnsAliasName));

jaredmoo · 2017-10-19T05:29:57Z

src/SDKs/SqlManagement/Sql.Tests/ServerDnsAliasCrudScenarioTests.cs

+    public class ServerDnsAliasCrudScenarioTests
+    {
+        [Fact]
+        public void TestCrudServerDnsAlias()


test looks good!

jaredmoo · 2017-10-19T05:30:17Z

src/SDKs/SqlManagement/Sql.Tests/Utilities/SqlManagementTestUtilities.cs

+        }

-        internal static Task<Database[]> CreateDatabasesAsync(
+		internal static Task<Database[]> CreateDatabasesAsync(


jaredmoo · 2017-10-19T05:30:44Z

src/SDKs/SqlManagement/Sql.Tests/Utilities/SqlManagementTestUtilities.cs

            Assert.Equal(expected.VirtualNetworkSubnetId, actual.VirtualNetworkSubnetId);
        }
+
+        public static void ValidateServerDnsAlias(ServerDnsAlias actual, string name)


I understand you're following the pattern here, but I think it would be better in your DNS alias test class

This reverts commit 5a5e426.

…g small change requests from Jared in pull request

* Regenerate SDK for new added api key management swagger spec (#3767) * Generate .NET SDK for application insights * update assembly version * address code review feedback * address code review feedback * regenerate sdk for adding management api keys functions * remove local used LaunchSettings.json file * generate from the pulic swagger * increase version in csproj file * Update Batch changelog to have a clearer format (#3775) * Removing build tools outside of branches (#3780) * Moving old files which are not used anymore to legacy directory * Separate build tools from branch. Moving forward build tools will be downloaded from a central location, this helps in propogating build changes to any branch dynamically. After this change build process on a new machine or fresh install will be a two step process. First download the build tools by executing msbuild build.proj and once it finishes, then execute whatever target you need to do e.g. msbuild build.proj /t:RunTests /p:Scope=SDKs\Compute. After downloading all build related assets will be downloaded under <root>\tools\SdkBuildTools. Moving bunch of legacy code to legacy directory. Removing build tasks out of this branch, currently being moved to legacy directory * Update README.md Updating readme to document recent build changes that were done to extract build tools out of main branch. * Adding data factory CRUD scenario test (#3774) * This is the first batch of scenario tests for the ADF V2 SDK. * Partially addresses #3726; more tests need to be added * Update Batch supporting assemblies (#3794) * [ADLA] - Update changelog for version 3.0.2 (#3792) * Merge from private Networking (#3771) * Regenerated Networking SDK on 2017-09-01, private * Expose new operation for VpnDeviceConfiguration for Vpn Gateways * Adding AzureReachabilityReport and AvailableProvidersList APIs + tests * Updating version of Network SDK * Disabling tests for AzureReachabilityReport and AvailableProvidersList APIs * Updated version * Caa record support in Azure DNS (#3785) * upgrade .net.test.sk project to stable version * support for CAA records * changing assembly file version to reflect nuget version * update swagger from public repo * addressing code review comments * bumping up assembly verson to 2.0.0.0 * [ADLA - ADLS] - [HOTFIX] - Update changelog (#3802) * [ADLA] - Update changelog for version 3.0.2 * [ADLA] - Update changelog * [ADLS] - Update changelog * Update changelog * 3.0.1 for ADLA was never published to nuget * 2.2.1 for ADLS was never published to nuget * Adding .NET SDK changes for Server DNS Aliasing (#3803) * Auto generated files for .NET SDK for Server DNS Aliasing. Also contains removing unused declarations from bunch of files. Everything generated automatically * Adding tests for server dns aliasing and their recording * Fixing sql_resource_manager.txt * Updating new version of SDK in AssemblyInfo.cs and csproj file * Small cosmetic changes to address Jared * Revert "Small cosmetic changes to address Jared" This reverts commit 5a5e426. * Reverting version change in project and AssemblyInfo files; addressing small change requests from Jared in pull request * [ACR] Update SDK to 2017-10-01 version (#3778) * Update ACR SDK to 2017-10-01 version * Update csproj, re-record tests * Address PR review feedback Address PR review feedback * Fix issue with missing Unit enumeration values, fix documentation issues, improved tests for multi-dim metrics API (#3809) * [Monitor] Fixing doc issues, adding two values to the metric unit enumeration, generating metadata files * Increasing version number due to a bug fix and documentation updates * [Monitor] Adding multi-dimensional metrics tests * Re-generate SDKs/Resource (#3793) * Updated Network SDK version (#3814) * Added Zone Redundant Property To Database, Elastic Pool and Edition Capability (#3800) * Add zone redundant property for database, elastic pool and capability edition * Added zone redundant property release notes * Revert "Removing build tools outside of branches (#3780)" This reverts commit deceaf3. * Revert "Revert "Removing build tools outside of branches (#3780)"" This reverts commit 58265b9. * Rerun tests to fix validation errors * Remove null capability test * Cancel pipeline run (#3812) * Cancel pipeline run api * Makin cancel run to factory operation * Example and unit test for cancel pipeline run api. * Regenerating SDK accoring to latest instructions * Scenario test for cancel run api * Scenario test for pipeline run 2 * Regenerating SDK and adding text file with generation metadata * Adding version 0.2.1 * Merged ADMS changes for Oct. SDK release * Add linked service scenario test (resolves #3726) (#3798) * Adds a simple CRUD test for linked services * Also change all tests to check for proper HTTP response codes on each API call * Resolves #3726 * Updated RecoveryServices.Backup Tests (#3822) - Updated tests to address Azure/azure-sdk-for-python#1422 - Updated test settings (VM name etc) for Backup tests and re-recorded tests

* Auto generated files for .NET SDK for Server DNS Aliasing. Also contains removing unused declarations from bunch of files. Everything generated automatically * Adding tests for server dns aliasing and their recording * Fixing sql_resource_manager.txt * Updating new version of SDK in AssemblyInfo.cs and csproj file * Small cosmetic changes to address Jared * Revert "Small cosmetic changes to address Jared" This reverts commit 5a5e426. * Reverting version change in project and AssemblyInfo files; addressing small change requests from Jared in pull request

maboja-msft added 4 commits October 18, 2017 19:40

Auto generated files for .NET SDK for Server DNS Aliasing. Also conta…

1907168

…ins removing unused declarations from bunch of files. Everything generated automatically

Adding tests for server dns aliasing and their recording

0d811d9

Fixing sql_resource_manager.txt

2c92d0f

Updating new version of SDK in AssemblyInfo.cs and csproj file

210d83d

jaredmoo suggested changes Oct 19, 2017

View reviewed changes

maboja-msft added 3 commits October 19, 2017 12:21

Small cosmetic changes to address Jared

5a5e426

Revert "Small cosmetic changes to address Jared"

f129d6e

This reverts commit 5a5e426.

Reverting version change in project and AssemblyInfo files; addressin…

a20934e

…g small change requests from Jared in pull request

jaredmoo approved these changes Oct 19, 2017

View reviewed changes

shahabhijeet merged commit 71f11d8 into Azure:psSdkJson6 Oct 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding .NET SDK changes for Server DNS Aliasing#3803

Adding .NET SDK changes for Server DNS Aliasing#3803
shahabhijeet merged 7 commits intoAzure:psSdkJson6from
maboja-msft:psSdkJson6

maboja-msft commented Oct 19, 2017 •

edited

Loading

Uh oh!

maboja-msft commented Oct 19, 2017

Uh oh!

jaredmoo left a comment

Uh oh!

jaredmoo Oct 19, 2017

Uh oh!

jaredmoo Oct 19, 2017

Uh oh!

jaredmoo Oct 19, 2017

Uh oh!

jaredmoo Oct 19, 2017

Uh oh!

jaredmoo Oct 19, 2017

Uh oh!

jaredmoo Oct 19, 2017

Uh oh!

jaredmoo Oct 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

maboja-msft commented Oct 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

maboja-msft commented Oct 19, 2017

Uh oh!

jaredmoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maboja-msft commented Oct 19, 2017 •

edited

Loading