Caa record support in Azure DNS by karravi-msft · Pull Request #3785 · Azure/azure-sdk-for-net

karravi-msft · 2017-10-13T22:11:38Z

Description

Changes to support new record type in DNS - CAA. Swagger PR @ Azure/azure-rest-api-specs#1835

This checklist is used to make sure that common guidelines for a pull request are followed.

[x ] I have read the contribution guidelines.
[x ] The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

shahabhijeet · 2017-10-16T18:42:46Z

src/SDKs/Dns/Dns.Tests/Dns.Tests.csproj

    <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
  </ItemGroup>
+  <ItemGroup>
+    <PackageReference Update="Microsoft.NET.Test.Sdk" Version="15.3.0" />


@karravi-msft this has been long ignore for your RP. Please use latest version of ResourceManager nuget 1.6.0 (at least) and re-record your tests.
This has been long been ignored because there have been cases where your nuget has to meet some deadline.
Please use the latest version of Resource manager nuget for your testing your management client.

shahabhijeet · 2017-10-16T18:46:30Z

src/SDKs/Dns/Management.Dns/Microsoft.Azure.Management.Dns.csproj

@@ -3,7 +3,7 @@
  <PropertyGroup>
    <PackageId>Microsoft.Azure.Management.Dns</PackageId>
    <Description>Provides management capabilities for Azure Dns.</Description>
-    <VersionPrefix>1.9.0-preview</VersionPrefix>
+    <VersionPrefix>1.10.0-preview</VersionPrefix>


@karravi-msft missing ReleaseNotes. Please model after
https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/BatchAI/Management.BatchAI/Microsoft.Azure.Management.BatchAI.csproj#L10

resolved.. thanks for the pointer

shahabhijeet · 2017-10-16T18:47:13Z

src/SDKs/Dns/Management.Dns/Generated/ZonesOperationsExtensions.cs

@@ -275,9 +272,9 @@ public static IPage<Zone> List(this IZonesOperations operations, int? top = defa
            /// zone. Specify the last-seen etag value to prevent accidentally deleting any
            /// concurrent changes.
            /// </param>
-            public static ZoneDeleteResult BeginDelete(this IZonesOperations operations, string resourceGroupName, string zoneName, string ifMatch = default(string))
+            public static void BeginDelete(this IZonesOperations operations, string resourceGroupName, string zoneName, string ifMatch = default(string))


@karravi-msft breaking change, please bump up major version.

shahabhijeet · 2017-10-16T18:47:26Z

src/SDKs/Dns/Management.Dns/Generated/ZonesOperationsExtensions.cs

@@ -129,12 +129,9 @@ public static ZoneDeleteResult Delete(this IZonesOperations operations, string r
            /// <param name='cancellationToken'>
            /// The cancellation token.
            /// </param>
-            public static async Task<ZoneDeleteResult> DeleteAsync(this IZonesOperations operations, string resourceGroupName, string zoneName, string ifMatch = default(string), CancellationToken cancellationToken = default(CancellationToken))
+            public static async Task DeleteAsync(this IZonesOperations operations, string resourceGroupName, string zoneName, string ifMatch = default(string), CancellationToken cancellationToken = default(CancellationToken))


@karravi-msft breaking change, please bump up major version.

shahabhijeet

@karravi-msft one minor comment that I believe you might have missed to update. This PR is ready to merge.

shahabhijeet · 2017-10-17T20:18:13Z

src/SDKs/Dns/Management.Dns/Properties/AssemblyInfo.cs

@@ -7,7 +7,7 @@
 [assembly: AssemblyTitle("Microsoft Azure DNS Management Library")]
 [assembly: AssemblyDescription("Provides management functionality for Microsoft Azure DNS Resources.")]
 [assembly: AssemblyVersion("1.0.0.0")]


@karravi-msft you missed bumping up AssemblyVersion. Please update AssemblyVersion to 2.0.0.0

* Regenerate SDK for new added api key management swagger spec (#3767) * Generate .NET SDK for application insights * update assembly version * address code review feedback * address code review feedback * regenerate sdk for adding management api keys functions * remove local used LaunchSettings.json file * generate from the pulic swagger * increase version in csproj file * Update Batch changelog to have a clearer format (#3775) * Removing build tools outside of branches (#3780) * Moving old files which are not used anymore to legacy directory * Separate build tools from branch. Moving forward build tools will be downloaded from a central location, this helps in propogating build changes to any branch dynamically. After this change build process on a new machine or fresh install will be a two step process. First download the build tools by executing msbuild build.proj and once it finishes, then execute whatever target you need to do e.g. msbuild build.proj /t:RunTests /p:Scope=SDKs\Compute. After downloading all build related assets will be downloaded under <root>\tools\SdkBuildTools. Moving bunch of legacy code to legacy directory. Removing build tasks out of this branch, currently being moved to legacy directory * Update README.md Updating readme to document recent build changes that were done to extract build tools out of main branch. * Adding data factory CRUD scenario test (#3774) * This is the first batch of scenario tests for the ADF V2 SDK. * Partially addresses #3726; more tests need to be added * Update Batch supporting assemblies (#3794) * [ADLA] - Update changelog for version 3.0.2 (#3792) * Merge from private Networking (#3771) * Regenerated Networking SDK on 2017-09-01, private * Expose new operation for VpnDeviceConfiguration for Vpn Gateways * Adding AzureReachabilityReport and AvailableProvidersList APIs + tests * Updating version of Network SDK * Disabling tests for AzureReachabilityReport and AvailableProvidersList APIs * Updated version * Caa record support in Azure DNS (#3785) * upgrade .net.test.sk project to stable version * support for CAA records * changing assembly file version to reflect nuget version * update swagger from public repo * addressing code review comments * bumping up assembly verson to 2.0.0.0 * [ADLA - ADLS] - [HOTFIX] - Update changelog (#3802) * [ADLA] - Update changelog for version 3.0.2 * [ADLA] - Update changelog * [ADLS] - Update changelog * Update changelog * 3.0.1 for ADLA was never published to nuget * 2.2.1 for ADLS was never published to nuget * Adding .NET SDK changes for Server DNS Aliasing (#3803) * Auto generated files for .NET SDK for Server DNS Aliasing. Also contains removing unused declarations from bunch of files. Everything generated automatically * Adding tests for server dns aliasing and their recording * Fixing sql_resource_manager.txt * Updating new version of SDK in AssemblyInfo.cs and csproj file * Small cosmetic changes to address Jared * Revert "Small cosmetic changes to address Jared" This reverts commit 5a5e426. * Reverting version change in project and AssemblyInfo files; addressing small change requests from Jared in pull request * [ACR] Update SDK to 2017-10-01 version (#3778) * Update ACR SDK to 2017-10-01 version * Update csproj, re-record tests * Address PR review feedback Address PR review feedback * Fix issue with missing Unit enumeration values, fix documentation issues, improved tests for multi-dim metrics API (#3809) * [Monitor] Fixing doc issues, adding two values to the metric unit enumeration, generating metadata files * Increasing version number due to a bug fix and documentation updates * [Monitor] Adding multi-dimensional metrics tests * Re-generate SDKs/Resource (#3793) * Updated Network SDK version (#3814) * Added Zone Redundant Property To Database, Elastic Pool and Edition Capability (#3800) * Add zone redundant property for database, elastic pool and capability edition * Added zone redundant property release notes * Revert "Removing build tools outside of branches (#3780)" This reverts commit deceaf3. * Revert "Revert "Removing build tools outside of branches (#3780)"" This reverts commit 58265b9. * Rerun tests to fix validation errors * Remove null capability test * Cancel pipeline run (#3812) * Cancel pipeline run api * Makin cancel run to factory operation * Example and unit test for cancel pipeline run api. * Regenerating SDK accoring to latest instructions * Scenario test for cancel run api * Scenario test for pipeline run 2 * Regenerating SDK and adding text file with generation metadata * Adding version 0.2.1 * Merged ADMS changes for Oct. SDK release * Add linked service scenario test (resolves #3726) (#3798) * Adds a simple CRUD test for linked services * Also change all tests to check for proper HTTP response codes on each API call * Resolves #3726 * Updated RecoveryServices.Backup Tests (#3822) - Updated tests to address Azure/azure-sdk-for-python#1422 - Updated test settings (VM name etc) for Backup tests and re-recorded tests

* upgrade .net.test.sk project to stable version * support for CAA records * changing assembly file version to reflect nuget version * update swagger from public repo * addressing code review comments * bumping up assembly verson to 2.0.0.0

karravi-msft added 4 commits September 29, 2017 14:49

upgrade .net.test.sk project to stable version

915d6e1

support for CAA records

f06852b

changing assembly file version to reflect nuget version

3a952f8

update swagger from public repo

6dffe94

shahabhijeet suggested changes Oct 16, 2017

View reviewed changes

shahabhijeet added the Changes Requested label Oct 16, 2017

addressing code review comments

a3555d8

shahabhijeet suggested changes Oct 17, 2017

View reviewed changes

bumping up assembly verson to 2.0.0.0

01a6cd4

shahabhijeet approved these changes Oct 18, 2017

View reviewed changes

shahabhijeet merged commit b290d04 into Azure:psSdkJson6 Oct 18, 2017

snyk-bot mentioned this pull request Nov 18, 2022

[Snyk] Upgrade @cspell/cspell-bundled-dicts from 5.21.2 to 6.13.1 akasya-alisveris-merkezleri/azure-sdk-for-net#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Caa record support in Azure DNS#3785

Caa record support in Azure DNS#3785
shahabhijeet merged 6 commits intoAzure:psSdkJson6from
karravi-msft:caa

karravi-msft commented Oct 13, 2017

Uh oh!

shahabhijeet Oct 16, 2017

Uh oh!

karravi-msft Oct 16, 2017

Uh oh!

shahabhijeet Oct 16, 2017

Uh oh!

karravi-msft Oct 16, 2017

Uh oh!

shahabhijeet Oct 16, 2017

Uh oh!

karravi-msft Oct 17, 2017

Uh oh!

shahabhijeet Oct 16, 2017

Uh oh!

karravi-msft Oct 16, 2017

Uh oh!

shahabhijeet left a comment

Uh oh!

shahabhijeet Oct 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

karravi-msft commented Oct 13, 2017

Description

Changes to support new record type in DNS - CAA. Swagger PR @ Azure/azure-rest-api-specs#1835

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shahabhijeet left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants