Swagger spec for Server DNS Aliasing by maboja-msft · Pull Request #1858 · Azure/azure-rest-api-specs

maboja-msft · 2017-10-13T01:37:10Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

maboja-msft · 2017-10-13T01:37:32Z

@jaredmoo @nathannfan Please comment

azuresdkciprbot · 2017-10-13T01:53:30Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jaredmoo

Overall looks great, minor comments. Please confirm that the service is in at least 1 production region and you have .net sdk tests passing that use code generated from this swagger.

jaredmoo · 2017-10-13T16:01:28Z

specification/sql/resource-manager/readme.md

 - Microsoft.Sql/2015-05-01-preview/syncMembers.json
 - Microsoft.Sql/2015-05-01-preview/virtualNetworkRules.json
 - Microsoft.Sql/2017-03-01-preview/cancelOperations.json
+- Microsoft.Sql/2017-03-01-preview/serverDnsAliases.json


please also add to schema-2017-03-preview section

This tag does not exist, so I have created it

jaredmoo · 2017-10-13T16:02:18Z

...on/sql/resource-manager/Microsoft.Sql/2017-03-01-preview/examples/ServerDnsAliasAcquire.json

+    "serverName": "dns-alias-new-server",
+    "dnsAliasName": "dns-alias-name-1",
+    "api-version": "2017-03-01-preview",
+	"parameters": {


nit: tabs/spaces here and in other example files

jaredmoo · 2017-10-13T16:03:31Z

specification/sql/resource-manager/Microsoft.Sql/2017-03-01-preview/serverDnsAliases.json

+          },
+          {
+            "$ref": "#/parameters/ApiVersionParameter"
+          }


is there no body parameter?

No, those requests don't have body

jaredmoo · 2017-10-13T16:04:55Z

specification/sql/resource-manager/Microsoft.Sql/2017-03-01-preview/serverDnsAliases.json

+      }
+    },
+    "ServerDnsAliasAcquisition": {
+      "description": "A server dns alias acquisition request.",


DNS or dns? Please pick one and stuck with it :)

…stly style)

azuresdkciprbot · 2017-10-13T23:48:42Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

salameer · 2017-10-17T22:54:43Z

Captain @alvadb

Ping on this one :)

maboja-msft · 2017-10-18T03:08:25Z

In response to Jared's comment: yes, service is in at least one production region (in fact it is deployed and working in all regions) and .net client tests are passing.

alvadb

Please fix example errors in next commit.

AutorestCI · 2017-10-18T20:56:08Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-10-18T20:59:03Z

Azure/azure-sdk-for-python#1550

AutorestCI · 2017-10-18T20:59:39Z

Azure/azure-sdk-for-ruby#1066

Swagger spec for Server DNS Aliasing

6ca9153

Fix path to example files in swagger file

c1a1dc8

azuresdkci assigned alvadb Oct 13, 2017

jaredmoo suggested changes Oct 13, 2017

View reviewed changes

Addressed first round of comments for pull request (small changes, mo…

54b43b8

…stly style)

alvadb approved these changes Oct 18, 2017

View reviewed changes

alvadb merged commit 5ff1e77 into Azure:current Oct 18, 2017

AutorestCI mentioned this pull request Oct 18, 2017

[SQL] Server DNS Aliasing Azure/azure-sdk-for-python#1550

Closed

AutorestCI mentioned this pull request Oct 18, 2017

Automatic PR from RestAPI-PR1858 Azure/azure-sdk-for-ruby#1066

Closed

maboja-msft mentioned this pull request Oct 19, 2017

Adding .NET SDK changes for Server DNS Aliasing Azure/azure-sdk-for-net#3803

Merged

8 tasks

Conversation

maboja-msft commented Oct 13, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

maboja-msft commented Oct 13, 2017

Uh oh!

azuresdkciprbot commented Oct 13, 2017

Uh oh!

jaredmoo left a comment

Choose a reason for hiding this comment

Uh oh!

jaredmoo Oct 13, 2017

Choose a reason for hiding this comment

Uh oh!

maboja-msft Oct 13, 2017

Choose a reason for hiding this comment

Uh oh!

jaredmoo Oct 13, 2017

Choose a reason for hiding this comment

Uh oh!

jaredmoo Oct 13, 2017

Choose a reason for hiding this comment

Uh oh!

maboja-msft Oct 13, 2017

Choose a reason for hiding this comment

Uh oh!

jaredmoo Oct 13, 2017

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Oct 13, 2017

Uh oh!

salameer commented Oct 17, 2017

Uh oh!

maboja-msft commented Oct 18, 2017

Uh oh!

alvadb left a comment

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Oct 18, 2017

Uh oh!

AutorestCI commented Oct 18, 2017

Uh oh!

AutorestCI commented Oct 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

maboja-msft commented Oct 13, 2017 •

edited by azuresdkci

Loading