Skip to content

Add DNS 2017-09-01 Swagger for CAA Record Support#1835

Merged
sergey-shandar merged 1 commit intoAzure:currentfrom
nkindberg:current
Oct 12, 2017
Merged

Add DNS 2017-09-01 Swagger for CAA Record Support#1835
sergey-shandar merged 1 commit intoAzure:currentfrom
nkindberg:current

Conversation

@nkindberg
Copy link
Copy Markdown
Contributor

@nkindberg nkindberg commented Oct 10, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/dns/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 17
After the PR: Warning(s): 0 Error(s): 13

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@nkindberg
Copy link
Copy Markdown
Contributor Author

These changes were already reviewed by @sergey-shandar in the private repo. Just moving everything as-is to the public repo.

@veronicagg
Copy link
Copy Markdown
Contributor

@nkindberg thanks for letting us know. @sergey-shandar could you confirm this and if so, approve and merge this PR? thanks!

@sergey-shandar
Copy link
Copy Markdown
Contributor

@sergey-shandar sergey-shandar merged commit 11d3fee into Azure:current Oct 12, 2017
@AutorestCI
Copy link
Copy Markdown

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

@AutorestCI
Copy link
Copy Markdown

@elyscape
Copy link
Copy Markdown

elyscape commented Dec 21, 2017

This does not appear to have been added to the SDKs for Ruby or Go. Both of them have support for the 2016-04-01 API but no newer.

@elyscape
Copy link
Copy Markdown

This is also the case for the Java SDK and Library.

@veronicagg
Copy link
Copy Markdown
Contributor

@elyscape that's correct for Ruby, this PR wasn't merged at the time we shipped spec updates to dns package. We're expecting to update packages based on specs for Ruby ~mid-Jan. If you need this one earlier, please let us know. - FYI @sarangan12

@elyscape
Copy link
Copy Markdown

@veronicagg Good to know. I personally only need a newer one for Go, but while I was source-diving I figured I'd check on the other SDKs. My need isn't particularly time-critical, but I wanted to make sure that it hadn't fallen off the radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants