Adding newly generated Vnet files#3537
Conversation
|
@dnayantara, |
|
Apologies for the multiple commits for numerous merges. I will make sure it does not happen going forward. |
|
@dnayantara, |
|
I dont understand. Yesterday it said all checks had passed. Why is build failing now? :( |
|
@azuresdkci test this please |
| /// <param name="state">Virtual network rule state. Possible values | ||
| /// include: 'Initializing', 'InProgress', 'Ready', 'Deleting', | ||
| /// 'Unknown'</param> | ||
| public VirtualNetworkRule(string virtualNetworkSubnetId, string id = default(string), string name = default(string), string type = default(string), bool? ignoreVnetPrivateAccessConfiguration = default(bool?), string state = default(string)) |
There was a problem hiding this comment.
@dnayantara you already have tests for the newly added parameter?
The description of the PR was confusing?
Yes the existing tests will work, but what about testing the new parameter?
There was a problem hiding this comment.
The code is not deployed in production yet. I will update the tests once that happens. Then new client code has been internally tested successfully.
|
The backend code is not yet in production. We cannot publish the nuget package with these changes unless everything is in production. |
5 participants
Adding the new regenerated Vnet files. Swagger changes in the pull request - Azure/azure-rest-api-specs#1492
This adds optional parameters so the current tests are successful as they are.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.