-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Adding newly generated Vnet files #3537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bad518d
Updating Virtual Network Rules tests with automatic vnet creation
NayantaraD 3128c08
Addressing comments to make the code more readable.
NayantaraD 6226294
Merge branch 'psSdkJson6' of https://github.com/azure/azure-sdk-for-n…
NayantaraD a788c58
Merge branch 'psSdkJson6' of https://github.com/azure/azure-sdk-for-n…
NayantaraD efcb5c4
Merge branch 'psSdkJson6' of https://github.com/azure/azure-sdk-for-n…
NayantaraD c7354f5
Merge branch 'psSdkJson6' of https://github.com/azure/azure-sdk-for-n…
NayantaraD 6bb8b1e
Adding regenerated vnet files
NayantaraD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
src/SDKs/SqlManagement/Management.Sql/Generated/Models/VirtualNetworkRuleState.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for | ||
| // license information. | ||
| // | ||
| // Code generated by Microsoft (R) AutoRest Code Generator. | ||
| // Changes may cause incorrect behavior and will be lost if the code is | ||
| // regenerated. | ||
|
|
||
| namespace Microsoft.Azure.Management.Sql.Models | ||
| { | ||
| using Microsoft.Azure; | ||
| using Microsoft.Azure.Management; | ||
| using Microsoft.Azure.Management.Sql; | ||
|
|
||
| /// <summary> | ||
| /// Defines values for VirtualNetworkRuleState. | ||
| /// </summary> | ||
| public static class VirtualNetworkRuleState | ||
| { | ||
| public const string Initializing = "Initializing"; | ||
| public const string InProgress = "InProgress"; | ||
| public const string Ready = "Ready"; | ||
| public const string Deleting = "Deleting"; | ||
| public const string Unknown = "Unknown"; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
345 changes: 200 additions & 145 deletions
345
...s/Sql.Tests.VirtualNetworkRulesCrudScenarioTests/TestCreateAndDropVirtualNetworkRule.json
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dnayantara you already have tests for the newly added parameter?
The description of the PR was confusing?
Yes the existing tests will work, but what about testing the new parameter?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is not deployed in production yet. I will update the tests once that happens. Then new client code has been internally tested successfully.