Updating swagger and examples for Vnet after adding migration flag + state by dnayantara · Pull Request #1492 · Azure/azure-rest-api-specs

dnayantara · 2017-07-29T00:08:01Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…state

jaredmoo · 2017-07-29T00:14:58Z

...rce-manager/Microsoft.Sql/2015-05-01-preview/examples/VirtualNetworkRulesCreateOrUpdate.json

              "properties": {
-                  "virtualNetworkSubnetId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default/providers/Microsoft.Network/virtualNetworks/testvnet/subnets/testsubnet"
+                "ignoreVnetPrivateAccessConfiguration": false,
+                "virtualNetworkSubnetId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default/providers/Microsoft.Network/virtualNetworks/testvnet/subnets/testsubnet"


"state" is missing from these responses

This will just be there in GET and LIST responses.

jaredmoo · 2017-07-29T00:15:30Z

specification/sql/resource-manager/Microsoft.Sql/2015-05-01-preview/virtualNetworkRules.json

  "swagger": "2.0",
  "info": {
-    "version": "2015-05-01-preview",
+    "version": "2.0",


jaredmoo · 2017-07-29T00:16:29Z

specification/sql/resource-manager/Microsoft.Sql/2015-05-01-preview/virtualNetworkRules.json

+          "type": "boolean"
+        },
+        "state": {
+          "description": "Virtual Network Rule State",


nit: don't use title casing, ie. change to Virtual network rule state

azuresdkciprbot · 2017-07-29T00:38:34Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 4 Error(s): 0
After the PR: Warning(s): 4 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

azuresdkciprbot · 2017-07-29T00:45:39Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 4 Error(s): 0
After the PR: Warning(s): 4 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

salameer · 2017-07-31T20:25:16Z

Hi @Sergey why is this not merged yet?

sergey-shandar · 2017-07-31T22:45:29Z

@salameer we had GitHub connection problem. I reviewed it (after several attempts) but I couldn't merge it at that time.

dnayantara · 2017-07-31T22:46:39Z

Thanks for the merge @sergey-shandar !

AutorestCI · 2017-07-31T23:05:49Z

Azure/azure-sdk-for-python#1339

AutorestCI · 2017-07-31T23:06:22Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-07-31T23:07:28Z

Azure/azure-sdk-for-ruby#872

* added x-ms-mutability and updated descriptions * Modifying some regex and fixing descriptions * Removing not specified * Onboarding Liftr categories and preferences Co-authored-by: Feng Wu <xuefwu@microsoft.com> Co-authored-by: Nicholas Rincon Reis <nireis@microsoft.com>

Updating swagger and examples for Vnet after adding migration flag + …

f9b9a14

…state

msftclas added the cla-not-required label Jul 29, 2017

jaredmoo suggested changes Jul 29, 2017

View reviewed changes

azuresdkci assigned sergey-shandar Jul 29, 2017

Addressing comments

b8e7914

jaredmoo approved these changes Jul 29, 2017

View reviewed changes

sergey-shandar approved these changes Jul 31, 2017

View reviewed changes

sergey-shandar merged commit 32a0602 into Azure:current Jul 31, 2017

AutorestCI mentioned this pull request Jul 31, 2017

[Network] Updating swagger and examples for Vnet after adding migration flag + state Azure/azure-sdk-for-python#1339

Closed

AutorestCI mentioned this pull request Jul 31, 2017

Automatic PR from RestAPI-PR1492 Azure/azure-sdk-for-ruby#872

Closed

dnayantara mentioned this pull request Aug 1, 2017

Adding newly generated Vnet files Azure/azure-sdk-for-net#3537

Closed

8 tasks

Copilot AI mentioned this pull request Feb 13, 2026

Skip setup-node when requested version already installed #40442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating swagger and examples for Vnet after adding migration flag + state#1492

Updating swagger and examples for Vnet after adding migration flag + state#1492
sergey-shandar merged 2 commits intoAzure:currentfrom
dnayantara:current

dnayantara commented Jul 29, 2017 •

edited by azuresdkci

Loading

Uh oh!

jaredmoo Jul 29, 2017

Uh oh!

dnayantara Jul 29, 2017

Uh oh!

jaredmoo Jul 29, 2017

Uh oh!

jaredmoo Jul 29, 2017

Uh oh!

azuresdkciprbot commented Jul 29, 2017

Uh oh!

azuresdkciprbot commented Jul 29, 2017

Uh oh!

salameer commented Jul 31, 2017

Uh oh!

sergey-shandar commented Jul 31, 2017

Uh oh!

dnayantara commented Jul 31, 2017

Uh oh!

AutorestCI commented Jul 31, 2017

Uh oh!

AutorestCI commented Jul 31, 2017

Uh oh!

AutorestCI commented Jul 31, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

dnayantara commented Jul 29, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

jaredmoo Jul 29, 2017

Choose a reason for hiding this comment

Uh oh!

dnayantara Jul 29, 2017

Choose a reason for hiding this comment

Uh oh!

jaredmoo Jul 29, 2017

Choose a reason for hiding this comment

Uh oh!

jaredmoo Jul 29, 2017

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Jul 29, 2017

Uh oh!

azuresdkciprbot commented Jul 29, 2017

Uh oh!

salameer commented Jul 31, 2017

Uh oh!

sergey-shandar commented Jul 31, 2017

Uh oh!

dnayantara commented Jul 31, 2017

Uh oh!

AutorestCI commented Jul 31, 2017

Uh oh!

AutorestCI commented Jul 31, 2017

Uh oh!

AutorestCI commented Jul 31, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dnayantara commented Jul 29, 2017 •

edited by azuresdkci

Loading