Skip to content

Network version update and ApplicationGateway New features#3418

Merged
shahabhijeet merged 5 commits into
Azure:psSdkJson6from
akshaysngupta:psSdkJson6
Jun 28, 2017
Merged

Network version update and ApplicationGateway New features#3418
shahabhijeet merged 5 commits into
Azure:psSdkJson6from
akshaysngupta:psSdkJson6

Conversation

@akshaysngupta
Copy link
Copy Markdown
Member

@akshaysngupta akshaysngupta commented Jun 26, 2017

This PR contains following changes:

  1. ApplicationGateway Ssl Policy custom cipher suites feature [new properties added to Sslpolicy Property of ApplciationGatewayPropertiesFormat]
  2. Get AvailableSslOption feature [new resource ApplicationGatewayAvailableSslOptions and child resource ApplicationGatewayPredefinedPolicy]
  3. Redirect Configuration feature [new child resource ApplicationGatewayRedirectConfiguration for Application Gateway, new properties in UrlPathMap, PathRules and RequestRoutingRule]
  4. Azure Websites feature [new properties in ApplicationGatewayBackendHttpSettingsPropertiesFormat, ApplicationGatewayProbePropertiesFormat, schema for property ApplicationGatewayProbeHealthResponseMatch]
  5. Version update for Network related services
  6. Tests in success state.

Associated pull request:
Azure/azure-rest-api-specs#1285
Azure/azure-rest-api-specs#1340
Azure/azure-rest-api-specs#1323
Azure/azure-rest-api-specs#1344

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

2 similar comments
@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@msftclas
Copy link
Copy Markdown

@akshaysngupta,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@akshaysngupta akshaysngupta force-pushed the psSdkJson6 branch 2 times, most recently from 516bc15 to d5b9cc8 Compare June 27, 2017 18:24
@shahabhijeet
Copy link
Copy Markdown
Contributor

@azuresdkci add to whitelist

@shahabhijeet
Copy link
Copy Markdown
Contributor

@akshaysngupta add to white list

@shahabhijeet
Copy link
Copy Markdown
Contributor

@azuresdkci test this please

1 similar comment
@shahabhijeet
Copy link
Copy Markdown
Contributor

@azuresdkci test this please

Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump up version of the nuget as well as assemblyfileversion.
As this is a breaking change due to api version change, will need to bump up Major version.

@shahabhijeet
Copy link
Copy Markdown
Contributor

@akshaysngupta please have Deepak approve or anyone from network approve these changes.

@akshaysngupta
Copy link
Copy Markdown
Member Author

I have changed the major version to 11.0.0.0 in assembly. I am not able to find project.json for Network.

@akshaysngupta
Copy link
Copy Markdown
Member Author

I have changed the major version to 11.0.0.0 in Network.csproj

@shahabhijeet
Copy link
Copy Markdown
Contributor

@akshaysngupta this is good to go, once @DeepakRajendranMsft approves it.

@shahabhijeet
Copy link
Copy Markdown
Contributor

@akshaysngupta please pull latest and revert your version change to accommodate already changed files in this PR #3414

@shahabhijeet shahabhijeet merged commit e32f6a0 into Azure:psSdkJson6 Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants