Skip to content

Add new properties for express route resources#3414

Merged
shahabhijeet merged 11 commits into
Azure:psSdkJson6from
dihan0604:psSdkJson6
Jun 28, 2017
Merged

Add new properties for express route resources#3414
shahabhijeet merged 11 commits into
Azure:psSdkJson6from
dihan0604:psSdkJson6

Conversation

@dihan0604
Copy link
Copy Markdown
Contributor

@dihan0604 dihan0604 commented Jun 23, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dihan0604
Copy link
Copy Markdown
Contributor Author

Swagger: Azure/azure-rest-api-specs#1310

Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any tests for this feature.
Please add test coverage for this feature.

@shahabhijeet
Copy link
Copy Markdown
Contributor

@dihan0604 please add needs-review label and assign it to me once you are done addressing the PR

@dihan0604
Copy link
Copy Markdown
Contributor Author

test coverage added

@dihan0604
Copy link
Copy Markdown
Contributor Author

@shahabhijeet , I have addressed your comments, could you take a look?

@shahabhijeet
Copy link
Copy Markdown
Contributor

@azuresdkci test this please

@shahabhijeet shahabhijeet merged commit f40f0bd into Azure:psSdkJson6 Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants