Skip to content

[#ApplicationGateway] Next link in PredefinedPolicies, predefinedPoliciesParam correction and version reverted#1340

Merged
dsgouda merged 1 commit into
Azure:masterfrom
akshaysngupta:master
Jun 23, 2017
Merged

[#ApplicationGateway] Next link in PredefinedPolicies, predefinedPoliciesParam correction and version reverted#1340
dsgouda merged 1 commit into
Azure:masterfrom
akshaysngupta:master

Conversation

@akshaysngupta
Copy link
Copy Markdown
Member

@akshaysngupta akshaysngupta commented Jun 22, 2017

Description

  • Added Next link field in PredefinedPolicies
  • Corrected predefined Policies Param which are defined in global context to local context
  • Reverted some versions of the file that were created in previous pull request to 2017-03-01 as they should be only updated by the team maintaining them.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@msftclas
Copy link
Copy Markdown

@akshaysngupta,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@akshaysngupta akshaysngupta changed the title Next link in PredefinedPolicies, predefinedPoliciesParam correction and version reverted [#ApplicationGateway] Next link in PredefinedPolicies, predefinedPoliciesParam correction and version reverted Jun 22, 2017
@azuresdkci
Copy link
Copy Markdown
Contributor

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: arm-network/2017-06-01/swagger/applicationGateway.json
Before the PR: Warning(s): 56 Error(s): 40
After the PR: Warning(s): 56 Error(s): 39

File: arm-network/2017-06-01/swagger/networkWatcher.json
Before the PR: Warning(s): 27 Error(s): 5
After the PR: Warning(s): 27 Error(s): 5

File: arm-network/2017-06-01/swagger/virtualNetwork.json
Before the PR: Warning(s): 45 Error(s): 17
After the PR: Warning(s): 45 Error(s): 17

File: arm-network/2017-06-01/swagger/vmssPublicIpAddress.json
Before the PR: Warning(s): 33 Error(s): 14
After the PR: Warning(s): 33 Error(s): 14

Thanks for your co-operation.

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@dsgouda dsgouda merged commit f98c73f into Azure:master Jun 23, 2017
@AutorestCI
Copy link
Copy Markdown

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants