A fix for filtering out non package line from msbuild#24950
Merged
sima-zhu merged 5 commits intoAzure:mainfrom Oct 27, 2021
Merged
A fix for filtering out non package line from msbuild#24950sima-zhu merged 5 commits intoAzure:mainfrom
sima-zhu merged 5 commits intoAzure:mainfrom
Conversation
sima-zhu
requested review from
chidozieononiwu,
danieljurek and
weshaggard
as code owners
sima-zhu
force-pushed
the
filter_out_nonpackage
branch
from
f9b8352 to
4b1e35d
Compare
weshaggard
reviewed
Oct 27, 2021
Contributor
Author
|
The fix of adding nologo works: |
sima-zhu
force-pushed
the
filter_out_nonpackage
branch
from
fdf45a1 to
516a3f3
Compare
weshaggard
reviewed
Oct 27, 2021
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
weshaggard
reviewed
Oct 27, 2021
weshaggard
approved these changes
Oct 27, 2021
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
One last suggestion but otherwise looks good.
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
ghost
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Oct 27, 2021
We currently do not populate {package}.json file for track 1 packages which is used to release step to read package properties.
However, we expect to support all packages which utilize our pipeline to release.
The PR is to remove the `new_sdk` check so that we generate and publish json file whenever they go through our pipelines.
The change failed at reading line from `msbuild` command. We are lack of ability to tell which line is "introduction message" , which line actually reading the package info.
Here is fix: Azure/azure-sdk-for-net#24950
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix can fix the failure dump step:
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.