Skip to content

A fix for filtering out non package line from msbuild #24950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sima-zhu merged 5 commits into from
Oct 27, 2021
Merged

A fix for filtering out non package line from msbuild #24950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
516a3f3
A fix of Nologo on msbuild.
sima-zhu Oct 27, 2021
7162b77
Update eng/pipelines/templates/variables/globals.yml
sima-zhu Oct 27, 2021
968544a
Added test path back
sima-zhu Oct 27, 2021
11bc886
Merge branch 'filter_out_nonpackage' of https://github.com/sima-zhu/a…
sima-zhu Oct 27, 2021
ba9584f
Update eng/scripts/Language-Settings.ps1
sima-zhu Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eng/pipelines/templates/variables/globals.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ variables:
DECODE_PERCENTS: false
NUGET_PACKAGES: $(Pipeline.Workspace)/.nuget/packages/
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1
DOTNET_NOLOGO: 1
4 changes: 4 additions & 0 deletions eng/scripts/Language-Settings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ function Get-AllPackageInfoFromRepo($serviceDirectory)

$pkgPath, $serviceDirectory, $pkgName, $pkgVersion, $sdkType, $isNewSdk = $projectOutput.Split(' ',[System.StringSplitOptions]::RemoveEmptyEntries).Trim("'")

if(!(Test-Path $pkgPath)) {
Write-Host "Parsed package path `$pkgPath` does not exist so skipping the package line '$projectOutput'."
continue
}
$pkgProp = [PackageProps]::new($pkgName, $pkgVersion, $pkgPath, $serviceDirectory)
$pkgProp.SdkType = $sdkType
$pkgProp.IsNewSdk = ($isNewSdk -eq 'true')
Expand Down