Skip to content

Conversation

@sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Oct 26, 2021

We currently do not populate {package}.json file for track 1 packages which is used to release step to read package properties.

However, we expect to support all packages which utilize our pipeline to release.

The PR is to remove the new_sdk check so that we generate and publish json file whenever they go through our pipelines.

The change failed at reading line from msbuild command. We are lack of ability to tell which line is "introduction message" , which line actually reading the package info.

Here is fix: Azure/azure-sdk-for-net#24950

@sima-zhu sima-zhu requested a review from a team as a code owner October 26, 2021 19:43
@sima-zhu sima-zhu requested review from weshaggard and removed request for a team October 26, 2021 19:44
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Can you please do some local testing to run this for each of our repos. You should be able to have it generate a json file for all libraries in the entire repo by passing in empty for the service directory.

@benbp benbp requested a review from ckairen October 26, 2021 21:45
@sima-zhu
Copy link
Contributor Author

@weshaggard Below shows my local generated files
image
The mgmt packages are able to generate.

@weshaggard
Copy link
Member

@sima-zhu I'm mostly wanted to ensure that the json files we wheren't generating before actually generate successfully and look as expected.

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Oct 26, 2021

@weshaggard I have simply verified in python repo.
The one with new_sdk check has 204 total json files
The one without new_sdk check has 266 total json files

We have azure-keyvault.json generated using current change as below:
image

@weshaggard
Copy link
Member

OK please double check at least .NET repo as well, in particular the issue we saw earlier today

@sima-zhu
Copy link
Contributor Author

My machine is out of date for dotnet tools. Will update my local and paste the result here later.

@sima-zhu
Copy link
Contributor Author

@weshaggard
Total json files:
With current changes: 150
Without current changes: 106

WebPubsub Common is here:
image

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Oct 27, 2021

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Oct 27, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 4628423 into Azure:main Oct 27, 2021
@sima-zhu sima-zhu deleted the remove_new_sdk_check branch October 27, 2021 21:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants