-
Notifications
You must be signed in to change notification settings - Fork 229
Remove the new sdk check and populate json for track 1 package #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following pipelines have been queued for testing: |
weshaggard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good. Can you please do some local testing to run this for each of our repos. You should be able to have it generate a json file for all libraries in the entire repo by passing in empty for the service directory.
|
@weshaggard Below shows my local generated files |
|
@sima-zhu I'm mostly wanted to ensure that the json files we wheren't generating before actually generate successfully and look as expected. |
|
@weshaggard I have simply verified in python repo. We have azure-keyvault.json generated using current change as below: |
|
OK please double check at least .NET repo as well, in particular the issue we saw earlier today |
|
My machine is out of date for dotnet tools. Will update my local and paste the result here later. |
|
@weshaggard |
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|



We currently do not populate {package}.json file for track 1 packages which is used to release step to read package properties.
However, we expect to support all packages which utilize our pipeline to release.
The PR is to remove the
new_sdkcheck so that we generate and publish json file whenever they go through our pipelines.The change failed at reading line from
msbuildcommand. We are lack of ability to tell which line is "introduction message" , which line actually reading the package info.Here is fix: Azure/azure-sdk-for-net#24950