Changing OR object to a list of the proper OR class #12740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnguye
requested review from
KrzysztofCwalina,
amishra-dev,
kasobol-msft,
pakrym,
seanmcc-msft and
tg-msft
as code owners
| /// </summary> | ||
| public class ObjectReplicationPolicy | ||
| { | ||
| internal ObjectReplicationPolicy() { } |
Contributor
There was a problem hiding this comment.
I think we have a SomethingFactory class where customers can create these for test purposes. We should add ORS entities there as well to factory method for the type enclosing them.
Member
There was a problem hiding this comment.
@amnguye you can add methods to create ObjectReplicationPolicy and ObjectReplicationRule in the BlobsModelFactory.
Contributor
|
Looks good (other than Factory thing). |
seanmcc-msft
approved these changes
Jun 12, 2020
Member
seanmcc-msft
left a comment
seanmcc-msft
left a comment
There was a problem hiding this comment.
Let's add the BlobModelFactory methods.
| BlobType blobType, | ||
| string versionId, | ||
| IDictionary<string, IDictionary<string, string>> objectReplicationSourceProperties, | ||
| IList<ObjectReplicationPolicy> objectReplicationSourceProperties, |
Contributor
There was a problem hiding this comment.
We should also add this to BlobDownloadDetails's factory.
kasobol-msft
approved these changes
Jun 12, 2020
This was referenced Jun 15, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-net
that referenced
this pull request
Feb 22, 2021
Default API version is now 2020-10-01 (Azure#12740)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ObjectReplication, replacing IDictionary<string, IDictionary<string, string> to IList, as per API View comment.
This will allow the user to know what property of the source OR properties they are accessing as well as giving the room to add more properties in the future.