Conversation
|
I don't know if |
|
@chradek Thanks for pulling up that PR, I was also worried that changing these might cause compiler-breaking changes. I ran API Extractor on these changes and it doesn't complain that we aren't exporting a type that is being used in either library. I also tried packing the library and using it in a very basic way, didn't see any compiler issues. The previous issue we saw with |
chradek
left a comment
There was a problem hiding this comment.
I downloaded @azure/core-http@1.0.0-preview.2 where we had made @types/tunnel a dependency again. @daviwil is right, the axios http client needed the types from tunnel. Now that we don't use axios I'm not concerned about tunnel given David's testing above.
|
Thanks for the extra verification @chradek! I'll merge this now. Thanks for sending the PR @JianpingChen! |
After that change, @types/node are no longer installed in-directly, which caused TypeScript compilation for consumers of @azure/core-http if they don't have @types/node as their dependencies.
Move the following dependencies from "dependencies" to "devDependencies".
"@types/node-fetch": "^2.5.0",
"@types/tunnel": "^0.0.1",