[core-http] Revert Changes in PR #8843#9276
Merged
jeremymeng merged 1 commit intoAzure:masterfrom Jun 4, 2020
Merged
Conversation
After that change, @types/node are no longer installed in-directly, which caused TypeScript compilation for consumers of @azure/core-http if they don't have @types/node as their dependencies.
jeremymeng
requested review from
bterlson,
chradek,
daviwil and
xirzec
as code owners
chradek
approved these changes
Jun 3, 2020
Member
|
Wouldn't a better solution be us directly depending on |
Member
Author
yeah, it's being discussed in the internal Teams and we think reverting is the safer short-term fix for this release. |
xirzec
approved these changes
Jun 3, 2020
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
Please file an issue to do a better fix in the next release ❤️
Member
Author
|
logged #9278 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After that change, @types/node are no longer installed in-directly,
which broke TypeScript compilation for consumers of @azure/core-http
if they don't have @types/node as their dependencies.