Remove dedupe from rollup config#4613
Merged
mikeharder merged 1 commit intoAzure:masterfrom Aug 7, 2019
Merged
Conversation
Member
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
KarishmaGhiya
approved these changes
Aug 1, 2019
Member
Author
|
Blocked on fix for rollup/rollup-plugin-commonjs#400 |
mikeharder
force-pushed
the
remove-rollup-dedupe
branch
3 times, most recently
from
4b5f7f8 to
d741435
Compare
Member
Author
|
This should be ready to merge after |
- Update transitive dependency resolve to 1.12.0 - Fixes issue with symlink resolution which required dedupe workaround - browserify/resolve#196 - Move buffer to full dependency of service-bus - Packages required for browser bundles should be full dependencies - Improves customer experience when generating bundles from our packages - Add dependencies buffer and process to event-hubs - Required to generate browser bundle - Fixes Azure#3326
mikeharder
force-pushed
the
remove-rollup-dedupe
branch
from
d741435 to
ecaacb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big thanks to @bterlson for finding the root cause and helping with the fix!
Changes to generated packages
It looks like
core-amqphad duplicatebufferin its bundle (which was previously unknown) but it's removed now. This caused changes in downstream .min.js and .map files. No other changes in generated packages.