Remove trailing slash from namedExports#4617
Merged
mikeharder merged 1 commit intoAzure:masterfrom Aug 1, 2019
Merged
Conversation
Member
mikeharder
commented
Aug 1, 2019
mikeharder
commented
- Was required due to Adding exports to CJS modules with built-in names broken by resolve 1.11.1 rollup/rollup-plugin-commonjs#394
- Fixed in rollup-plugin-commonjs@1.10.1
- Was required due to rollup/rollup-plugin-commonjs#394 - Fixed in rollup-plugin-commonjs@1.10.1
mikeharder
requested review from
HarshaNalluru,
ShivangiReja,
XiaoningLiu,
chradek,
daviwil,
jeremymeng,
ramya-rao-a,
sadasant,
sophiajt and
vinjiang
as code owners
daviwil
approved these changes
Aug 1, 2019
Contributor
daviwil
left a comment
daviwil
left a comment
There was a problem hiding this comment.
So nice to get rid of this!
Member
Author
HarshaNalluru
approved these changes
Aug 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.