[Docs][EH,SB] update README to not install buffer and process for browsers#26101
Merged
jeremymeng merged 1 commit intoAzure:mainfrom Jun 5, 2023
Merged
Conversation
…wsers As they are dependencies of the libraries and will be installed when installing EH or SB packages.
Collaborator
|
API change check API changes are not detected in this pull request. |
deyaaeldeen
approved these changes
Jun 5, 2023
Member
deyaaeldeen
left a comment
deyaaeldeen
left a comment
There was a problem hiding this comment.
It feels weird though that they're dependencies of those libraries but not any other library. Generally speaking, what is the problem if the customer were to install them themselves?
Member
Author
I didn't realize they are until your comments. I had thought that our libraries would just use the nodejs builtin, and only browsers need the npm packages for polyfills. I will have to dig the history to find out. |
Member
Author
minhanh-phan
pushed a commit
to minhanh-phan/azure-sdk-for-js
that referenced
this pull request
Jun 12, 2023
…wsers (Azure#26101) As they are dependencies of the libraries and will be installed when installing EH or SB packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As they are dependencies of the libraries and will be installed when installing EH or SB packages.