[mgmt] publish samples for advisor#37003
Merged
MaryGao merged 1 commit intoAzure:mainfrom Jan 13, 2026
Merged
Conversation
github-actions
bot
added
the
Mgmt
MaryGao
approved these changes
Jan 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the TypeScript and JavaScript sample files for the @azure/arm-advisor package, resolving inconsistencies between the samples and samples-dev folders caused by two previous PRs that modified these folders independently.
Changes:
- Modernized sample code structure with updated copyright headers, improved imports (using
dotenv/configandimport type), and added explicitPromise<void>return types - Updated dependencies to current versions (TypeScript ~5.9.3, @azure/identity ^4.13.0) and added cross-env to devDependencies
- Enhanced code quality with const declarations in loops, proper await usage, and trailing commas for better maintainability
Reviewed changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/advisor/arm-advisor/samples/v3/typescript/tsconfig.json | Updated compiler options to ES2023 target with stricter type checking and modern module resolution |
| sdk/advisor/arm-advisor/samples/v3/typescript/src/*.ts | Modernized all TypeScript samples with new header format, import type syntax, Promise return types, and improved code style |
| sdk/advisor/arm-advisor/samples/v3/typescript/package.json | Updated TypeScript and @azure/identity versions, added cross-env and "cloud" keyword |
| sdk/advisor/arm-advisor/samples/v3/typescript/README.md | Improved documentation by clarifying "required" environment variables and adding npx prefix to cross-env command |
| sdk/advisor/arm-advisor/samples/v3/javascript/*.js | Modernized all JavaScript samples with new header format, dotenv/config import, and improved code style with const and await |
| sdk/advisor/arm-advisor/samples/v3/javascript/package.json | Updated @azure/identity version, added cross-env devDependency and "cloud" keyword |
| sdk/advisor/arm-advisor/samples/v3/javascript/README.md | Improved documentation by clarifying "required" environment variables and adding npx prefix to cross-env command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from these two PRs:
#36198
#35609
These two have respectively modified the contents of the "samples" and "samples-dev" folders, resulting in inconsistency between the contents of these two folders