[mgmt] publish samples for advisor

sdk/advisor/arm-advisor/samples/v3/javascript/README.md

@@ -47,10 +47,10 @@ npm install
 node configurationsCreateInResourceGroupSample.js
 ```
 
-Alternatively, run a single sample with the correct environment variables set (setting up the `.env` file is not required if you do this), for example (cross-platform):
+Alternatively, run a single sample with the required environment variables set (setting up the `.env` file is not required if you do this), for example (cross-platform):
 
 ```bash
-cross-env ADVISOR_SUBSCRIPTION_ID="<advisor subscription id>" node configurationsCreateInResourceGroupSample.js
+npx cross-env ADVISOR_SUBSCRIPTION_ID="<advisor subscription id>" node configurationsCreateInResourceGroupSample.js
 ```
 
 ## Next Steps

sdk/advisor/arm-advisor/samples/v3/javascript/configurationsCreateInResourceGroupSample.js

@@ -1,23 +1,17 @@
-/*
- * Copyright (c) Microsoft Corporation.
- * Licensed under the MIT License.
- *
- * Code generated by Microsoft (R) AutoRest Code Generator.
- * Changes may cause incorrect behavior and will be lost if the code is regenerated.
- */
-
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-const { AdvisorManagementClient } = require("@azure/arm-advisor");
-const { DefaultAzureCredential } = require("@azure/identity");
-require("dotenv").config();
 
 /**
  * This sample demonstrates how to Create/Overwrite Azure Advisor configuration.
  *
  * @summary Create/Overwrite Azure Advisor configuration.
  * x-ms-original-file: specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/CreateConfiguration.json
  */
+
+const { AdvisorManagementClient } = require("@azure/arm-advisor");
+const { DefaultAzureCredential } = require("@azure/identity");
+require("dotenv/config");
+
 async function putConfigurations() {
   const subscriptionId = process.env["ADVISOR_SUBSCRIPTION_ID"] || "subscriptionId";
   const configurationName = "default";
@@ -48,13 +42,13 @@ async function putConfigurations() {
   const result = await client.configurations.createInResourceGroup(
     configurationName,
     resourceGroup,
-    configContract
+    configContract,
   );
   console.log(result);
 }
 
 async function main() {
-  putConfigurations();
+  await putConfigurations();
 }
 
 main().catch(console.error);

sdk/advisor/arm-advisor/samples/v3/javascript/configurationsCreateInSubscriptionSample.js

@@ -1,23 +1,17 @@
-/*
- * Copyright (c) Microsoft Corporation.
- * Licensed under the MIT License.
- *
- * Code generated by Microsoft (R) AutoRest Code Generator.
- * Changes may cause incorrect behavior and will be lost if the code is regenerated.
- */
-
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-const { AdvisorManagementClient } = require("@azure/arm-advisor");
-const { DefaultAzureCredential } = require("@azure/identity");
-require("dotenv").config();
 
 /**
  * This sample demonstrates how to Create/Overwrite Azure Advisor configuration and also delete all configurations of contained resource groups.
  *
  * @summary Create/Overwrite Azure Advisor configuration and also delete all configurations of contained resource groups.
  * x-ms-original-file: specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/CreateConfiguration.json
  */
+
+const { AdvisorManagementClient } = require("@azure/arm-advisor");
+const { DefaultAzureCredential } = require("@azure/identity");
+require("dotenv/config");
+
 async function putConfigurations() {
   const subscriptionId = process.env["ADVISOR_SUBSCRIPTION_ID"] || "subscriptionId";
   const configurationName = "default";
@@ -46,13 +40,13 @@ async function putConfigurations() {
   const client = new AdvisorManagementClient(credential, subscriptionId);
   const result = await client.configurations.createInSubscription(
     configurationName,
-    configContract
+    configContract,
   );
   console.log(result);
 }
 
 async function main() {
-  putConfigurations();
+  await putConfigurations();
 }
 
 main().catch(console.error);

sdk/advisor/arm-advisor/samples/v3/javascript/configurationsListByResourceGroupSample.js

@@ -1,37 +1,31 @@
-/*
- * Copyright (c) Microsoft Corporation.
- * Licensed under the MIT License.
- *
- * Code generated by Microsoft (R) AutoRest Code Generator.
- * Changes may cause incorrect behavior and will be lost if the code is regenerated.
- */
-
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-const { AdvisorManagementClient } = require("@azure/arm-advisor");
-const { DefaultAzureCredential } = require("@azure/identity");
-require("dotenv").config();
 
 /**
  * This sample demonstrates how to Retrieve Azure Advisor configurations.
  *
  * @summary Retrieve Azure Advisor configurations.
  * x-ms-original-file: specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/ListConfigurations.json
  */
+
+const { AdvisorManagementClient } = require("@azure/arm-advisor");
+const { DefaultAzureCredential } = require("@azure/identity");
+require("dotenv/config");
+
 async function getConfigurations() {
   const subscriptionId = process.env["ADVISOR_SUBSCRIPTION_ID"] || "subscriptionId";
   const resourceGroup = "resourceGroup";
   const credential = new DefaultAzureCredential();
   const client = new AdvisorManagementClient(credential, subscriptionId);
   const resArray = new Array();
-  for await (let item of client.configurations.listByResourceGroup(resourceGroup)) {
+  for await (const item of client.configurations.listByResourceGroup(resourceGroup)) {
     resArray.push(item);
   }
   console.log(resArray);
 }
 
 async function main() {
-  getConfigurations();
+  await getConfigurations();
 }
 
 main().catch(console.error);

sdk/advisor/arm-advisor/samples/v3/javascript/configurationsListBySubscriptionSample.js

@@ -1,36 +1,30 @@
-/*
- * Copyright (c) Microsoft Corporation.
- * Licensed under the MIT License.
- *
- * Code generated by Microsoft (R) AutoRest Code Generator.
- * Changes may cause incorrect behavior and will be lost if the code is regenerated.
- */
-
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-const { AdvisorManagementClient } = require("@azure/arm-advisor");
-const { DefaultAzureCredential } = require("@azure/identity");
-require("dotenv").config();
 
 /**
  * This sample demonstrates how to Retrieve Azure Advisor configurations and also retrieve configurations of contained resource groups.
  *
  * @summary Retrieve Azure Advisor configurations and also retrieve configurations of contained resource groups.
  * x-ms-original-file: specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/ListConfigurations.json
  */
+
+const { AdvisorManagementClient } = require("@azure/arm-advisor");
+const { DefaultAzureCredential } = require("@azure/identity");
+require("dotenv/config");
+
 async function getConfigurations() {
   const subscriptionId = process.env["ADVISOR_SUBSCRIPTION_ID"] || "subscriptionId";
   const credential = new DefaultAzureCredential();
   const client = new AdvisorManagementClient(credential, subscriptionId);
   const resArray = new Array();
-  for await (let item of client.configurations.listBySubscription()) {
+  for await (const item of client.configurations.listBySubscription()) {
     resArray.push(item);
   }
   console.log(resArray);
 }
 
 async function main() {
-  getConfigurations();
+  await getConfigurations();
 }
 
 main().catch(console.error);

sdk/advisor/arm-advisor/samples/v3/javascript/package.json

@@ -16,7 +16,8 @@
     "azure",
     "typescript",
     "browser",
-    "isomorphic"
+    "isomorphic",
+    "cloud"
   ],
   "author": "Microsoft Corporation",
   "license": "MIT",
@@ -27,6 +28,9 @@
   "dependencies": {
     "@azure/arm-advisor": "latest",
     "dotenv": "latest",
-    "@azure/identity": "^4.2.1"
+    "@azure/identity": "^4.13.0"
+  },
+  "devDependencies": {
+    "cross-env": "latest"
   }
 }

sdk/advisor/arm-advisor/samples/v3/javascript/recommendationMetadataGetSample.js

@@ -1,23 +1,17 @@
-/*
- * Copyright (c) Microsoft Corporation.
- * Licensed under the MIT License.
- *
- * Code generated by Microsoft (R) AutoRest Code Generator.
- * Changes may cause incorrect behavior and will be lost if the code is regenerated.
- */
-
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-const { AdvisorManagementClient } = require("@azure/arm-advisor");
-const { DefaultAzureCredential } = require("@azure/identity");
-require("dotenv").config();
 
 /**
  * This sample demonstrates how to Gets the metadata entity.
  *
  * @summary Gets the metadata entity.
  * x-ms-original-file: specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/GetRecommendationMetadataEntity.json
  */
+
+const { AdvisorManagementClient } = require("@azure/arm-advisor");
+const { DefaultAzureCredential } = require("@azure/identity");
+require("dotenv/config");
+
 async function getMetadata() {
   const name = "types";
   const credential = new DefaultAzureCredential();
@@ -27,7 +21,7 @@ async function getMetadata() {
 }
 
 async function main() {
-  getMetadata();
+  await getMetadata();
 }
 
 main().catch(console.error);

sdk/advisor/arm-advisor/samples/v3/javascript/recommendationMetadataListSample.js

@@ -1,35 +1,29 @@
-/*
- * Copyright (c) Microsoft Corporation.
- * Licensed under the MIT License.
- *
- * Code generated by Microsoft (R) AutoRest Code Generator.
- * Changes may cause incorrect behavior and will be lost if the code is regenerated.
- */
-
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-const { AdvisorManagementClient } = require("@azure/arm-advisor");
-const { DefaultAzureCredential } = require("@azure/identity");
-require("dotenv").config();
 
 /**
  * This sample demonstrates how to Gets the list of metadata entities.
  *
  * @summary Gets the list of metadata entities.
  * x-ms-original-file: specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/ListRecommendationMetadata.json
  */
+
+const { AdvisorManagementClient } = require("@azure/arm-advisor");
+const { DefaultAzureCredential } = require("@azure/identity");
+require("dotenv/config");
+
 async function getMetadata() {
   const credential = new DefaultAzureCredential();
   const client = new AdvisorManagementClient(credential);
   const resArray = new Array();
-  for await (let item of client.recommendationMetadata.list()) {
+  for await (const item of client.recommendationMetadata.list()) {
     resArray.push(item);
   }
   console.log(resArray);
 }
 
 async function main() {
-  getMetadata();
+  await getMetadata();
 }
 
 main().catch(console.error);

sdk/advisor/arm-advisor/samples/v3/javascript/recommendationsGenerateSample.js

@@ -1,23 +1,17 @@
-/*
- * Copyright (c) Microsoft Corporation.
- * Licensed under the MIT License.
- *
- * Code generated by Microsoft (R) AutoRest Code Generator.
- * Changes may cause incorrect behavior and will be lost if the code is regenerated.
- */
-
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-const { AdvisorManagementClient } = require("@azure/arm-advisor");
-const { DefaultAzureCredential } = require("@azure/identity");
-require("dotenv").config();
 
 /**
  * This sample demonstrates how to Initiates the recommendation generation or computation process for a subscription. This operation is asynchronous. The generated recommendations are stored in a cache in the Advisor service.
  *
  * @summary Initiates the recommendation generation or computation process for a subscription. This operation is asynchronous. The generated recommendations are stored in a cache in the Advisor service.
  * x-ms-original-file: specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/GenerateRecommendations.json
  */
+
+const { AdvisorManagementClient } = require("@azure/arm-advisor");
+const { DefaultAzureCredential } = require("@azure/identity");
+require("dotenv/config");
+
 async function generateRecommendations() {
   const subscriptionId = process.env["ADVISOR_SUBSCRIPTION_ID"] || "subscriptionId";
   const credential = new DefaultAzureCredential();
@@ -27,7 +21,7 @@ async function generateRecommendations() {
 }
 
 async function main() {
-  generateRecommendations();
+  await generateRecommendations();
 }
 
 main().catch(console.error);

sdk/advisor/arm-advisor/samples/v3/javascript/recommendationsGetGenerateStatusSample.js

@@ -1,23 +1,17 @@
-/*
- * Copyright (c) Microsoft Corporation.
- * Licensed under the MIT License.
- *
- * Code generated by Microsoft (R) AutoRest Code Generator.
- * Changes may cause incorrect behavior and will be lost if the code is regenerated.
- */
-
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-const { AdvisorManagementClient } = require("@azure/arm-advisor");
-const { DefaultAzureCredential } = require("@azure/identity");
-require("dotenv").config();
 
 /**
  * This sample demonstrates how to Retrieves the status of the recommendation computation or generation process. Invoke this API after calling the generation recommendation. The URI of this API is returned in the Location field of the response header.
  *
  * @summary Retrieves the status of the recommendation computation or generation process. Invoke this API after calling the generation recommendation. The URI of this API is returned in the Location field of the response header.
  * x-ms-original-file: specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/EmptyResponse.json
  */
+
+const { AdvisorManagementClient } = require("@azure/arm-advisor");
+const { DefaultAzureCredential } = require("@azure/identity");
+require("dotenv/config");
+
 async function getGenerateStatus() {
   const subscriptionId = process.env["ADVISOR_SUBSCRIPTION_ID"] || "subscriptionId";
   const operationId = "operationGUID";
@@ -28,7 +22,7 @@ async function getGenerateStatus() {
 }
 
 async function main() {
-  getGenerateStatus();
+  await getGenerateStatus();
 }
 
 main().catch(console.error);