[EngSys] remove dev-tool run vendored from individual packages#36198
Merged
jeremymeng merged 10 commits intoAzure:mainfrom Oct 13, 2025
Merged
[EngSys] remove dev-tool run vendored from individual packages#36198jeremymeng merged 10 commits intoAzure:mainfrom
dev-tool run vendored from individual packages#36198jeremymeng merged 10 commits intoAzure:mainfrom
Conversation
These tool include `cross-env`, `eslint`, `prettier`, `rimraf`. The Pnpm docs recommend including dependencies in individual packages package.json and only keeping tools needed for mono-repo maintenance in the global package.json
use "pnpm pack" now that we have workspace/catalog version specifiers
jeremymeng
requested review from
a team,
JacksonWeber,
Karlie-777,
MSNev,
MaryGao,
benbp,
deyaaeldeen,
hectorhdzg,
jeremydvoss,
lzchen,
maorleger,
mikeharder,
qiaozha,
rads-1996,
srnagar,
timovv and
weshaggard
as code owners
jeremymeng
requested review from
a team,
EldertGrootenboer,
aditishree1,
alexathomases,
amanrao23,
blueww,
jiacfan,
johngallardo,
koen-mertens,
ljian3377,
olivakar,
rajeshka,
sajeetharan,
shankarsama,
sjiherzig,
skarri-microsoft,
tomsft,
topshot99 and
vinjiang
as code owners
maorleger
approved these changes
Oct 13, 2025
Member
maorleger
left a comment
maorleger
left a comment
There was a problem hiding this comment.
🚀 🥳
(huge PR but looks pretty mechanical, had copilot summarize the changes)
Member
Author
|
Going to override unrelated test failures. |
Member
Author
|
/check-enforcer override |
maorleger
approved these changes
Oct 13, 2025
Member
|
@jeremymeng I met an error when running this is because in this pr , mkdirp was added in devDependencies generation, but this pr removed it in pnpm-workspace.yaml, I think we should remove this in codegen? |
Member
Author
|
@kazrael2119 yes we need to merge Azure/autorest.typescript#3536 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary reason that we added
dev-tool run vendoredcommand is to managedependencies centrally. Now we can achieve that with pnpm workspace/catalog
feature. This PR removes most of the
dev-tool run vendoredusages fromindividual packages and replace them with direct tool calls. Those tools are
also added to individual package's dev dependencies per Pnpm recommendation.