Skip to content

[App Configuration] - Make list label test deterministic #35952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

[App Configuration] - Make list label test deterministic #35952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a4e4c5
make listlabel test deterministic
zhiyuanliang-ms Sep 16, 2025
20300d2
update recording
zhiyuanliang-ms Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/appconfiguration/app-configuration/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "js",
"TagPrefix": "js/appconfiguration/app-configuration",
"Tag": "js/appconfiguration/app-configuration_d666a5f99b"
"Tag": "js/appconfiguration/app-configuration_bdaf29d71a"
}
10 changes: 9 additions & 1 deletion sdk/appconfiguration/app-configuration/test/public/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,12 @@ describe("AppConfigurationClient", () => {
});

it("basic list labels", async () => {
const labelsIterator = client.listLabels();
// Use nameFilter to make the test deterministic in live mode.
// Without this, parallel CI jobs (or other tests) that introduce an unlabeled setting
// can cause an additional { name: null } label to appear between successive enumerations
// in `toSortedLabelsArray`, leading to a mismatch. Filtering ensures we only retrieve
// the label created for this test.
const labelsIterator = client.listLabels({ nameFilter: uniqueLabel });
const byLabelSettings = await toSortedLabelsArray(labelsIterator);
assert.deepEqual(
[
Expand Down Expand Up @@ -648,7 +653,10 @@ describe("AppConfigurationClient", () => {
});

it("Using `select` via `fields`", async () => {
// Add nameFilter to eliminate interference from concurrently added labels (null or others)
// in live CI runs. This keeps the test focused on field selection behavior.
const labelsIterator = client.listLabels({
nameFilter: uniqueLabel,
fields: ["name"],
});

Expand Down