Skip to content

Renaming diagnostic api to getCosmosResponseDiagnostics() #6264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simplynaveen20 merged 2 commits into from
Nov 15, 2019
Merged

Renaming diagnostic api to getCosmosResponseDiagnostics() #6264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87869b0
renaming diagnostic api
simplynaveen20 Nov 11, 2019
3c77102
Merge branch 'feature/cosmos/v4' into user/nakumars/renamingDiagnosti…
simplynaveen20 Nov 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public Map<String, String> getResponseHeaders() {
*
* @return diagnostics information for the current request to Azure Cosmos DB service.
*/
public CosmosResponseDiagnostics getCosmosResponseDiagnosticsString() {
public CosmosResponseDiagnostics getCosmosResponseDiagnostics() {
return resourceResponseWrapper.getCosmosResponseDiagnostics();
}

Expand Down
6 changes: 3 additions & 3 deletions sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/CollectionCrudTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,12 @@ public void sessionTokenConsistencyCollectionDeleteCreateSameName() {
CosmosItemRequestOptions options = new CosmosItemRequestOptions();
options.setPartitionKey(new PartitionKey("mypkValue"));
CosmosAsyncItemResponse readDocumentResponse = item.read(options).block();
logger.info("Client 1 READ Document Client Side Request Statistics {}", readDocumentResponse.getCosmosResponseDiagnosticsString());
logger.info("Client 1 READ Document Client Side Request Statistics {}", readDocumentResponse.getCosmosResponseDiagnostics());
logger.info("Client 1 READ Document Latency {}", readDocumentResponse.getRequestLatency());

BridgeInternal.setProperty(document, "name", "New Updated Document");
CosmosAsyncItemResponse upsertDocumentResponse = collection.upsertItem(document).block();
logger.info("Client 1 Upsert Document Client Side Request Statistics {}", upsertDocumentResponse.getCosmosResponseDiagnosticsString());
logger.info("Client 1 Upsert Document Client Side Request Statistics {}", upsertDocumentResponse.getCosmosResponseDiagnostics());
logger.info("Client 1 Upsert Document Latency {}", upsertDocumentResponse.getRequestLatency());

// DELETE the existing collection
Expand All @@ -285,7 +285,7 @@ public void sessionTokenConsistencyCollectionDeleteCreateSameName() {
createDocument(collection2, newDocument);

readDocumentResponse = client1.getDatabase(dbId).getContainer(collectionId).getItem(newDocument.getId(), newDocument.get("mypk")).read().block();
logger.info("Client 2 READ Document Client Side Request Statistics {}", readDocumentResponse.getCosmosResponseDiagnosticsString());
logger.info("Client 2 READ Document Client Side Request Statistics {}", readDocumentResponse.getCosmosResponseDiagnostics());
logger.info("Client 2 READ Document Latency {}", readDocumentResponse.getRequestLatency());

CosmosItemProperties readDocument = readDocumentResponse.getProperties();
Expand Down