Added @JsonIgnore to getLogger in JsonSerializable

[kushagraThapar]

• Added @JsonIgnore to getLogger in JsonSerializable
• Updated version to 3.3.1
• This fix is intended for the issue faced in spring-data-cosmsodb SDK: Sorting throws exception when pageSize is less than total items in repository microsoft/spring-data-cosmosdb#423

[kushagraThapar]

/azp run java - cosmos - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mbhaskar]

Just to double check - 3.4.0 was just a snapshot right?

[kushagraThapar]

Not anymore.
The practice has been changed to update the versions to next to be released version.

[mbhaskar]

Please refrain from making unrelated formatting changes, you can configure intellij to stop doing this automatically

[kushagraThapar]

I really wanted to, but couldn't stop it. :(
You can show me a demo sometime :)

[JimSuplizio]

CC: @weshaggard
@kushagraThapar Why is the version of this ticked back down from 3.4.0 to 3.3.1? Is this supposed to be a hotfix? For hotfixes we generally recommend branching from the last release tag (https://github.com/Azure/azure-sdk/blob/master/docs/policies/repobranching.md#hotfix-branches) and applying just the fix you want, otherwise you risk picking up other changes you didn't want for that hotfix.

Last but not least, when versioning files please take a look at the Versions and versioning section of https://github.com/Azure/azure-sdk-for-java/blob/master/CONTRIBUTING.md. The versions of Cosmos versions should be updated in version_data.txt and then the update_versions.py script should be run which will update the pom and readme files. There's a secondary PR for this to update the version in java files as well which is going to run into merge issues of these version changes.

[kushagraThapar]

CC: @weshaggard
@kushagraThapar Why is the version of this ticked back down from 3.4.0 to 3.3.1? Is this supposed to be a hotfix? For hotfixes we generally recommend branching from the last release tag (https://github.com/Azure/azure-sdk/blob/master/docs/policies/repobranching.md#hotfix-branches) and applying just the fix you want, otherwise you risk picking up other changes you didn't want for that hotfix.

Last but not least, when versioning files please take a look at the Versions and versioning section of https://github.com/Azure/azure-sdk-for-java/blob/master/CONTRIBUTING.md. The versions of Cosmos versions should be updated in version_data.txt and then the update_versions.py script should be run which will update the pom and readme files. There's a secondary PR for this to update the version in java files as well which is going to run into merge issues of these version changes.

@JimSuplizio, this wasn't a hotfix, but more like a small bug fix (that was needed in spring-data-cosmosdb SDK) that wasn't related to any previous changes.
Since the master wasn't updated since release 3.3.0, so released it from master itself.
This PR: #5959 changes the version back to 3.4.0 to avoid any confusion.

Going forward, I will make sure to create a hotfix branch, and follow the hotfix pattern for any bug fixes, or hotfixes releases.

Regarding tags, I couldn't find any tags under azure-sdk-for-java that were related to cosmos SDK previous releases. Since cosmos SDK and azure-sdk-for-java follow different release cycles, how can we create tags for previous versions that got released, and for this release as well?

Also, do we need to update version_data.txt every time we release a new cosmos SDK version?

For now, I can create a PR that updates the version_data.txt file. Will that be okay?

[weshaggard]

Regarding tags, I couldn't find any tags under azure-sdk-for-java that were related to cosmos SDK previous releases. Since cosmos SDK and azure-sdk-for-java follow different release cycles, how can we create tags for previous versions that got released, and for this release as well?

The github UI doesn't do well with listing all the tags I suggest using the command line git tag -l azure-cosmos* should find you all the release tags for cosmos. Currently it only lists 3.2.2 but I suspect that is because the 3.3.0 package must not have been released with the correct release pipeline.