Removed BadRequestException when FeedOptions.maxItemCount is -1 #5618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushagraThapar
requested review from
christopheranderson and
moderakh
as code owners
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mbhaskar
approved these changes
Oct 2, 2019
Member
mbhaskar
left a comment
mbhaskar
left a comment
There was a problem hiding this comment.
Looks good. Minor thing, but you may avoid the unrelated formatting changes.
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mbhaskar
pushed a commit
to mbhaskar/azure-sdk-for-java
that referenced
this pull request
Oct 23, 2019
kushagraThapar
pushed a commit
that referenced
this pull request
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of SDK throwing BadRequestException when maxItemCount is less than 0.
Azure/azure-cosmosdb-java#261