Skip to content

Resolves issues 275 and 276 #5829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mitchdenny merged 1 commit into from
Oct 15, 2019
Merged

Resolves issues 275 and 276 #5829

mitchdenny merged 1 commit into from
Oct 15, 2019

Conversation

@David-Noble-at-work
Copy link

@David-Noble-at-work David-Noble-at-work commented Oct 14, 2019

This change resolves:

kushagraThapar
kushagraThapar approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kushagraThapar
Copy link
Member

kushagraThapar commented Oct 15, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 15, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor

mitchdenny commented Oct 15, 2019

Merging after conversation with @kushagraThapar

@mitchdenny mitchdenny merged commit cda87f6 into Azure:master Oct 15, 2019
mbhaskar pushed a commit to mbhaskar/azure-sdk-for-java that referenced this pull request Oct 23, 2019
Resolves issues 275 and 276
14a28fe 
port from: Azure#5829
@mbhaskar mbhaskar mentioned this pull request Oct 23, 2019
Merged
kushagraThapar pushed a commit that referenced this pull request Oct 24, 2019
@mbhaskar @kushagraThapar
Porting fixes from v3 to v4 (#6012)
2fcfa5d 
* Porting JsonIgnore fix
port from: #5951

* Removed BadRequestException when FeedOptions.maxItemCount is -1
Port from: #5618

* Retry not happening with direct mode - port to v4
Port from: #5806

* Resolves issues 275 and 276
port from: #5829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@moderakh moderakh Awaiting requested review from moderakh

Assignees

No one assigned

Labels

Cosmos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@David-Noble-at-work @kushagraThapar @mitchdenny @mbhaskar