-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Pass package info to the API review and package validation pipelines #47335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the pipeline configuration by switching from passing Artifacts parameter to PackageInfoFiles parameter when calling the API review and package validation templates. Both templates now support the PackageInfoFiles parameter, which provides a more direct way to specify package information files rather than constructing them from artifact names.
- Replaces
Artifactsparameter withPackageInfoFilesin template calls tocreate-apireview.ymlandvalidate-all-packages.yml - Constructs explicit file paths for each package info JSON file using
${{ each artifact }}loops - Maintains backward compatibility as the underlying templates still support both parameters with proper fallback logic
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/templates/stages/archetype-java-release-patch.yml | Updates create-apireview template call to use PackageInfoFiles instead of Artifacts parameter |
| eng/pipelines/templates/stages/archetype-java-release-batch.yml | Updates create-apireview template call to use PackageInfoFiles instead of Artifacts parameter |
| eng/pipelines/templates/jobs/ci.yml | Updates both create-apireview and validate-all-packages template calls to use PackageInfoFiles instead of Artifacts parameter |
|
This PR has to wait after the PR is merged. |
Make this input switch from
artifactstopackageInfosince both of the 'API Review' pipeline and 'Validate Package` pipeline had supported this.Test runs:
patch-release
template-batch-release