Skip to content

Pass package info to the API review and package validation pipelines #47335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 21, 2025
+20 −4
Merged

Pass package info to the API review and package validation pipelines #47335

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6e54fbd
Passed the package info for apireview and validate package pipeline
raych1 Nov 19, 2025
d30b6c3
Added test pipeline variable to patch release pipeline
raych1 Nov 19, 2025
f59a790
Fixed JSON conversion error on windows os
raych1 Nov 19, 2025
bb71ea9
Used compile time variable format
raych1 Nov 19, 2025
559b223
Escaped forward slash in path
raych1 Nov 19, 2025
47afd32
Used parameter instead
raych1 Nov 19, 2025
5c70a9e
Escaped forward slash
raych1 Nov 19, 2025
e2c28bc
replaced the backslash
raych1 Nov 19, 2025
3be018c
Updated test pipeline input
raych1 Nov 19, 2025
2164e7c
Updated yml to use the array object
raych1 Nov 20, 2025
7cef9b6
Dynamic loaded the artifact for set test pipeline version template
raych1 Nov 20, 2025
765bfa7
Apply suggestions from code review
raych1 Nov 20, 2025
0d2dff2
Apply suggestions from code review
raych1 Nov 20, 2025
db878ea
Added display name for testPipeline parameter
raych1 Nov 20, 2025
ae13f13
Reverted change of set-test-pipeline-version template reference
raych1 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/common/pipelines/templates/steps/create-apireview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ steps:
inputs:
filePath: ${{ parameters.SourceRootPath }}/eng/common/scripts/Create-APIReview.ps1
arguments: >
-PackageInfoFiles ('${{ convertToJson(parameters.PackageInfoFiles) }}' | ConvertFrom-Json -NoEnumerate)
-PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\\', '/') }}' | ConvertFrom-Json -NoEnumerate)
-ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name)
-ArtifactPath '${{parameters.ArtifactPath}}'
-ArtifactName ${{ parameters.ArtifactName }}
Expand Down
2 changes: 1 addition & 1 deletion eng/common/pipelines/templates/steps/validate-all-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ steps:
-BuildDefinition $(System.CollectionUri)$(System.TeamProject)/_build?definitionId=$(System.DefinitionId) `
-PipelineUrl $(System.CollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId) `
-IsReleaseBuild $$(SetAsReleaseBuild) `
-PackageInfoFiles ('${{ convertToJson(parameters.PackageInfoFiles) }}' | ConvertFrom-Json -NoEnumerate)
-PackageInfoFiles ('${{ replace(convertToJson(parameters.PackageInfoFiles), '\\', '/') }}' | ConvertFrom-Json -NoEnumerate)
workingDirectory: $(Pipeline.Workspace)
displayName: Validate packages and update work items
continueOnError: true
Expand Down
7 changes: 7 additions & 0 deletions eng/pipelines/patch-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
trigger: none
pr: none

parameters:
- name: TestPipeline
type: boolean
default: false

extends:
template: /eng/pipelines/templates/stages/archetype-sdk-client-patch.yml
parameters:
TestPipeline: ${{ parameters.TestPipeline }}
artifacts:
- name: azure-sdk-template
groupId: com.azure
Expand Down
8 changes: 6 additions & 2 deletions eng/pipelines/templates/jobs/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,13 +260,17 @@ jobs:

- template: /eng/common/pipelines/templates/steps/create-apireview.yml
parameters:
Artifacts: ${{parameters.ReleaseArtifacts}}
PackageInfoFiles:
- ${{ each artifact in parameters.ReleaseArtifacts }}:
- $(Build.ArtifactStagingDirectory)/PackageInfo/${{artifact.name}}.json

- template: /eng/common/pipelines/templates/steps/detect-api-changes.yml

- template: /eng/common/pipelines/templates/steps/validate-all-packages.yml
parameters:
Artifacts: ${{ parameters.Artifacts }}
PackageInfoFiles:
- ${{ each artifact in parameters.Artifacts }}:
- $(Build.ArtifactStagingDirectory)/PackageInfo/${{artifact.name}}.json

- template: /eng/pipelines/templates/steps/post-job-cleanup.yml

Expand Down
4 changes: 3 additions & 1 deletion eng/pipelines/templates/stages/archetype-java-release-batch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,10 @@ stages:

- template: /eng/common/pipelines/templates/steps/create-apireview.yml
parameters:
PackageInfoFiles:
- ${{ each artifact in parameters.Artifacts }}:
- $(Pipeline.Workspace)/packages-signed/PackageInfo/${{artifact.name}}.json
ArtifactPath: $(Pipeline.Workspace)/packages-signed
Artifacts: ${{parameters.Artifacts}}
ConfigFileDir: $(Pipeline.Workspace)/packages-signed/PackageInfo
MarkPackageAsShipped: true
ArtifactName: packages-signed
Expand Down
4 changes: 3 additions & 1 deletion eng/pipelines/templates/stages/archetype-java-release-patch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,10 @@ stages:
ArtifactPath: $(Pipeline.Workspace)/packages-signed
- template: /eng/common/pipelines/templates/steps/create-apireview.yml
parameters:
PackageInfoFiles:
- ${{ each artifact in parameters.Artifacts }}:
- $(Pipeline.Workspace)/packages-signed/PackageInfo/${{artifact.name}}.json
ArtifactPath: $(Pipeline.Workspace)/packages-signed
Artifacts: ${{parameters.Artifacts}}
ConfigFileDir: $(Pipeline.Workspace)/packages-signed/PackageInfo
MarkPackageAsShipped: true
ArtifactName: packages-signed
Expand Down
Loading