-
Notifications
You must be signed in to change notification settings - Fork 221
Used another way to create package info array #13009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a JSON parse error that occurred when passing Windows file paths through the convertToJson Azure Pipelines template function. The error Bad JSON escape sequence: \a was caused by backslashes in paths like D:\a\_work\1\... being interpreted as escape characters when the JSON string was parsed by PowerShell's ConvertFrom-Json.
The fix replaces the JSON serialization/deserialization approach with a simpler PowerShell array construction using the join template expression.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/common/pipelines/templates/steps/validate-all-packages.yml | Changes -PackageInfoFiles parameter construction from JSON conversion to direct array syntax using join |
| eng/common/pipelines/templates/steps/create-apireview.yml | Changes -PackageInfoFiles parameter construction from JSON conversion to direct array syntax using join |
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13009 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: ray chen <[email protected]>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13009 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: ray chen <[email protected]>
Fixed a JSON parse error:
Test run:
template-batch-release