Update CODEOWNERS paths: fix invalid paths and deprioritize /eng/ and Engineering System Team paths
#33221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
requested review from
jsquire and
ronniegeraghty
as code owners
benbp
approved these changes
Jan 31, 2023
Contributor
Author
|
/check-enforcer override |
weshaggard
reviewed
Jan 31, 2023
konrad-jamrozik
commented
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of ongoing work of enabling wildcard support for
CODEOWNERS:and enabling stricter validation:
this PR:
/eng/dir and Azure SDK Engineering System team , to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supportingCODEOWNERSmatcher, per: Enable the new, regex-based, wildcard-supporting CODEOWNERS matcher azure-sdk-tools#5088 (comment)As a consequence of this PR possibly the automatically assigned PR reviewers will change for some paths. The full list of of such changes can be determined by running relevant test provided by this PR:
CODEOWNERSmatcher on all remaining repositories in scope. azure-sdk-tools#5266You can also reach out to me to get that information.
Once this PR is merged, I will enable the new
CODEOWNERSmatcher, similar to how it was done fornetrepo by these two PRs:azure-sdk-for-netrepo azure-sdk-tools#5241NotificationConfigurationpackage from20230119.1to20230127.4azure-sdk-tools#5240Doing so will also change to whom build failure notification emails are sent.
Related PRs:
netrepo: Fix invalid paths in CODEOWNERS azure-sdk-for-net#33584pythonrepo: DeprioritizeCODEOWNERSEngSys ownership + fix one invalid path azure-sdk-for-python#28534Build failure notification recipients changes
For a build definition whose source is
PATH, now its build failure notification recipients will beRIGHT OWNERS, while previously they whereLEFT OWNERS: