Fix Infinite Recursion on Self Reference #22583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
EngSys
alzimmermsft
requested review from
JimSuplizio,
danieljurek,
mitchdenny and
weshaggard
as code owners
Member
Author
|
/azp run java - storage |
Member
Author
|
/azp run java - spring |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
rnpmsft
pushed a commit
to rnpmsft/azure-sdk-for-java
that referenced
this pull request
Jun 25, 2021
srnagar
approved these changes
Jun 25, 2021
alzimmermsft
deleted the
AzEng_FixInfiniteRecursionWithSelfReferenceInGenerateFromSourceScript
branch
kasobol-msft
pushed a commit
that referenced
this pull request
Jun 28, 2021
* Setup packages for the data movement library (#22303) * Removed blob data movement package, renamed common data movement to d… (#22430) * Refactored test header logic into a global spock extension * Added version tag for assembly dependency * Resolved infinite recursion on self-dependency in generate_from_source_pom.py * Changed infinite recursion fix to @alzimmermsft implementation from #22583 * Created TestNameProvider, decoupled TestHeaderExtension/StorageSpec * Removed duplicate header print, changed maven execution id's to prevent overriding parent POM + better relay execution goals, removed maven self-dependency (now using surefire classpath dependency) * Changed surefire dependency to local repository (resists edge case user changes to target path), fixed assembly paths for *nix-compatibility * Removed DMLib WIP files to merge into main * Changed TestHeaderExtension from groovy to java for consistency, renamed variables/class names for clarity, final on new classes Co-authored-by: Gauri Prasad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.