Skip to content

Fix Infinite Recursion on Self Reference #22583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alzimmermsft merged 1 commit into from
Jun 25, 2021
Merged

Fix Infinite Recursion on Self Reference #22583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/scripts/generate_from_source_pom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@ def resolve_dependent_project(pom_identifier: str, dependent_modules: list, depe
for dependency in dependency_to_project_mapping[pom_identifier]:
# Only continue if the project's dependents haven't already been resolved.
if not dependency in dependent_modules:
dependent_modules = resolve_dependent_project(dependency, dependent_modules, dependency_to_project_mapping)
dependent_modules.append(dependency)
dependent_modules = resolve_dependent_project(dependency, dependent_modules, dependency_to_project_mapping)

return dependent_modules

Expand All @@ -200,8 +200,8 @@ def resolve_project_dependencies(pom_identifier: str, dependency_modules: list,
for dependency in project_dependencies_mapping[pom_identifier]:
# Only continue if the project's dependencies haven't already been resolved.
if not dependency in dependency_modules:
dependency_modules = resolve_project_dependencies(dependency, dependency_modules, project_dependencies_mapping)
dependency_modules.append(dependency)
dependency_modules = resolve_project_dependencies(dependency, dependency_modules, project_dependencies_mapping)

return dependency_modules

Expand Down