Skip to content

Commit e545cf6

Browse files
authored
Fix Infinite Recursion on Self Reference (#22583)
1 parent d23200e commit e545cf6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

eng/scripts/generate_from_source_pom.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,8 @@ def resolve_dependent_project(pom_identifier: str, dependent_modules: list, depe
189189
for dependency in dependency_to_project_mapping[pom_identifier]:
190190
# Only continue if the project's dependents haven't already been resolved.
191191
if not dependency in dependent_modules:
192-
dependent_modules = resolve_dependent_project(dependency, dependent_modules, dependency_to_project_mapping)
193192
dependent_modules.append(dependency)
193+
dependent_modules = resolve_dependent_project(dependency, dependent_modules, dependency_to_project_mapping)
194194

195195
return dependent_modules
196196

@@ -200,8 +200,8 @@ def resolve_project_dependencies(pom_identifier: str, dependency_modules: list,
200200
for dependency in project_dependencies_mapping[pom_identifier]:
201201
# Only continue if the project's dependencies haven't already been resolved.
202202
if not dependency in dependency_modules:
203-
dependency_modules = resolve_project_dependencies(dependency, dependency_modules, project_dependencies_mapping)
204203
dependency_modules.append(dependency)
204+
dependency_modules = resolve_project_dependencies(dependency, dependency_modules, project_dependencies_mapping)
205205

206206
return dependency_modules
207207

0 commit comments

Comments
 (0)